magithub icon indicating copy to clipboard operation
magithub copied to clipboard

Published 20 hours ago • verified publisher icon vermiculus

magithub-browse-file-blame

Open stardiviner opened this issue 7 years ago • 4 comments

This is a new continue of issue https://github.com/vermiculus/magithub/pull/377#issuecomment-423781610 The command magithub-browse-file-blame opened URL with wrong commit hash.

stardiviner avatar Sep 25 '18 23:09 stardiviner

That function uses the full hash of HEAD for the URL. What is that hash? git rev-parse HEAD

vermiculus avatar Sep 26 '18 00:09 vermiculus

It is f92a80c18ddc7faae5ed30c76cad47bd4551607f result from git rev-parse HEAD.

stardiviner avatar Sep 26 '18 11:09 stardiviner

I will take a look at github-browse-file-blame tomorrow.

stardiviner avatar Sep 26 '18 11:09 stardiviner

I checked out github-browse-file-blame. Have not found any obviously different with magithub-browse-file-blame. magithub-browse-file-blame use git re-parse HEAD. But github-browse-blame seems does not use that. I can't find where it get the commit hash. weird. I checked function github-browse-file--browse-url, not found.

stardiviner avatar Sep 27 '18 04:09 stardiviner