magithub

magithub copied to clipboard

It would be nice if user can customize the way how issue list is displayed, for example, I want to put the issue labels right after the issue title:

issue-id issue-title issue-labels

Out of curiosity, why? For a more birds-eye view, perhaps? (Just trying to understand the UX aspect 😄)

Because issue labels itself (and other attributes of issue) can be useful for users just like issue ID and issue title.

For me, if issue labels is displayed alongside with issue title, I might be able to

• know issue labels of an issue immediately without doing anything else
• search issue by labels with ordinary Emacs functions like Isearch and Occur
• click the label to filter issues like the github web interface

click the label to filter issues like the github web interface

That by itself is an interesting idea; can you create a new issue for that? 😄 The development will be different.

search issue by labels with ordinary Emacs functions like Isearch and Occur

This is something that I do miss from the earlier implementation. I'll just have to work out how to do this flexibly and in a way that makes sense UX-wise (since the individual issue section could be closed while the label section remains visible on the first line). @tarsius, any thoughts to that specifically? Basically, we have

[section] Issue title... [section]label 1[/section] [section]label 2[/section]
more issue content on
more lines
[/section]

Is there a way to make the label section a tab-target when visible even if the parent is in a closed state?

Finding "more issue content" might or might not work. Automatically expanding sections to make matches visible most certainly does not work.

But if I understand correctly this is only about finding the labels which are visible even if the body of the parent section is not visible. I am not sure if this works, but it might. The searching should not be an issue at all, but magit's own section movement and visibility commands might trip over it, or not.

Usually a section spans at least a complete line, but there are already a few sections that don't. The commit names inserted by magit-insert-revision-headers don't occupy a complete line, but they are also not inserted into the header of the parent.

I do know that when child sections are in the header line of a collapsed parent, movement commands won't see the section. I'm not sure if the section itself is even exposed, but I can try to verify that this week.

Is the section movement framework something you're planning to change or would you be open to a PR?

Is the section movement framework something you're planning to change or would you be open to a PR?

Eventually yes. I plan to use Eieio for sections, but hope that I can keep big parts of the existing implementation anyway. Actually I am going to merge a branch containing first steps toward the use of Eieio today. You should of course wait until that is done.

I am open to a pull-request that allows finding sections in the "heading", but it depends on how large such a change would be. Maybe it is just a matter of beginning the search for children earlier in a few functions, but if this requires more fare reaching changes, then I might not want to merge or at least delay doing so until the dust around Eieio has settled a bit.

Related somewhat to #179.