satori

satori copied to clipboard

Fixes #597 with correct regex.

Data URL Specification

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
satori-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 15, 2024 9:25am

Just tested this out, doesn't seem to work: playground link

@steven-tey Thank you for your report. I found out that this PR fixes an another issue. Updated issue number.

Thanks @kiwiyou! Could you please add a test case for it so it won't regress in the future?

@shuding Added 2 tests. I deliberately excluded tests for unsupported charsets. (e.g. charset=iso-8859-7)

Edit: NVM, just saw your comment here https://github.com/vercel/satori/issues/592#issuecomment-1979586066

Really appreciate your work on this @kiwiyou, but from the latest preview URL, this doesn't seem to work:

(PNG tab)

@shuding Could you review this PR?

it still doesn't seem to work in my case too, Playground url

@ducan-ne It works on my machine, could you describe the step to reproduce the bug?

@kiwiyou I don't know it just shows me a error when use the playground

@ducan-ne Your example works fine. Did you use the playground provided for this PR?

@shuding Do you have any blockades for the review?

@kiwiyou it works the first time but not after that, try enter something to the editor (use my reproduce url)

the evidence:

@ducan-ne Your problem seems to be the case for #592, not #597 here.