react-native-map-clustering icon indicating copy to clipboard operation
react-native-map-clustering copied to clipboard

onRegionChangeComplete wrong second parameter

Open mp3por opened this issue 3 years ago • 3 comments

You are passing a wrong parameter to onRegionChangeComplete from the MapView. It has to be const details = { isGesture }; but you are passing an array of markers.

Please pass the correct 2nd parameter or update the documentation to show this decision and provide a way to know if the it was a gesture update or not.

I (and many others probably) need to know if the update was user-initiated or not.

Possible solution image

I created a PR

mp3por avatar Sep 09 '22 08:09 mp3por

I see the same issue but I dont see the PR

kivancimer avatar Dec 06 '22 21:12 kivancimer

You are passing a wrong parameter to onRegionChangeComplete from the MapView. It has to be const details = { isGesture }; but you are passing an array of markers.

Please pass the correct 2nd parameter or update the documentation to show this decision and provide a way to know if the it was a gesture update or not.

I (and many others probably) need to know if the update was user-initiated or not.

Possible solution image

I created a PR

did you find a solution to this?

Falco26 avatar Sep 14 '23 13:09 Falco26