Robert van Gent

Results 114 comments of Robert van Gent

Sorry, it's hard for me to debug this since I can't reproduce. Can you use `gohack` to download Go CDK locally and debug? https://github.com/rogpeppe/gohack I.e., you could add a `fmt.Printf,...

Looks like this was done on purpose...? https://github.com/google/go-cloud/blob/012388aa3abfa3b3114d1ff9cb0f0c3d0ff4385c/server/requestlog/requestlog.go#L55 also refers to this behavior. Based on the comments, the tradeoff is incorrect request size being logged?

SGTM. A minor alternative change would be to drop #3 by always using the # of bytes read by the handler (as in #2) if it ready any. This seems...

Per-driver package parameters have to be explicitly supported. We just haven't done so for RabbitMQ. Can you send a PR?

Can you try 2) ? From a quick glance, [firebase.Storage](https://github.com/firebase/firebase-admin-go/blob/master/firebase.go) just creates a `storage.Client` the same way that Go CDK does, and (firebase App](https://github.com/firebase/firebase-admin-go/blob/master/firebase.go#L96) just calls [firebase.Storage` with whatever client...

I've been trying to upgrade to the new SDK for `pubsub` (#3084) but have been blocked on https://github.com/Azure/azure-sdk-for-go/issues/17472#issuecomment-1097185034. Basically, the new Azure packages only work with Go 1.18+, and go-cloud...

And yes, it will be a breaking change. Sadly there is no way to avoid that when the underlying provider makes breaking changes :-(.

Yes, looks like 1.19 should be out in August. I usually just note breaking changes in the release notes.

https://github.com/google/go-cloud/pull/3156 if you have any feedback.

@xaxa06 @toddself @stanhu @chrismellard @Strife96 FYI previous contributors to this package. I'm planning to update it in a non-backwards-compatible way soon, to update to the new Azure Blob Storage SDK....