ltex-ls icon indicating copy to clipboard operation
ltex-ls copied to clipboard
verified publisher icon valentjn

Add support for `aarch64` and `x86` architectures in releases

Open mrtnvgr opened this issue 3 years ago • 7 comments

This PR closes #229.

mrtnvgr avatar Mar 03 '23 00:03 mrtnvgr

arm64 -> aarch64

qRoC avatar Mar 16 '23 14:03 qRoC

@qRoC Hi! Can I ask you a question? Why did you remove x86-32 on your fork? Should I remove it here too?

mrtnvgr avatar Mar 16 '23 15:03 mrtnvgr

Hello, just for test. 11.0.12+7 does not contain some builds, 11.0.18+10 does not work:

Error: Hash of java.rmi (473234ff9c6b66f15c4c94acc5549542f361dac6bbfd0b08656e41f82867ac6e) differs to expected hash (d625849d78bdbbf431092f79032f21ddf8e8c1dfc48c9ac63132d598931b527d) recorded in java.base

Now I'm analyzing the problem, and then I'll return x86-32 back

qRoC avatar Mar 16 '23 15:03 qRoC

https://github.com/qRoC/ltex-ls/releases/tag/nightly

qRoC avatar Mar 16 '23 17:03 qRoC

https://github.com/qRoC/ltex-ls/releases/tag/nightly

Thank you for testing my PR!

mrtnvgr avatar Mar 16 '23 23:03 mrtnvgr

@qRoC I looked though your commits. I will be really nice if you make a PR about java version bump. 🤗

mrtnvgr avatar Mar 17 '23 00:03 mrtnvgr

If the author shows up, I'll do it

qRoC avatar Mar 17 '23 16:03 qRoC