Fakery icon indicating copy to clipboard operation
Fakery copied to clipboard

Published 20 hours ago • verified publisher icon vadymmarkov

Should we split up en.json into separate files?

Open dunyakirkali opened this issue 6 years ago • 2 comments

The current structure (a single en.json file) makes it difficult to contribute to this repository.

When there is more than 1 PR pending, once the first one gets merged it always creates merge-conflicts for the one after

dunyakirkali avatar May 09 '19 13:05 dunyakirkali

That's true, but I'm afraid it will make the parsing logic more complicated. Also, if we do it for en.json file it means we should probably do it for other locales, which could also be a problem.

vadymmarkov avatar May 09 '19 14:05 vadymmarkov

True that! I’ll try to create something as a POC and discuss with u further how we can tackle the issue

dunyakirkali avatar May 09 '19 14:05 dunyakirkali