rejson-rb

rejson-rb copied to clipboard

Added Support for RedisJSON 2.0 full JSONPath syntax

@urmilkalaria this merge request looks excellent! @vachhanihpavan are you still actively maintaining this Gem? If not maybe we could ask @byroot to pull it in to the main gem?

@urmilkalaria this merge request looks excellent! @vachhanihpavan are you still actively maintaining this Gem? If not maybe we could ask @byroot to pull it in to the main gem?

Hi @tinco, I was waiting for replies to my comments. I don't mind if @byroot can pull it into the main gem. I am not actively tracking updates to RedisJSON so, it'll be good if someone can take this project forward.

I don't plan to support extensions in redis-rb, the default commands are already a very large API to maintain.

It's best to stay as a separate gem.

Additionally this one still isn't updated to work with redis-rb 5.x, and use another testing framework, so it would be a PITA to merge in.

If you don't plan to maintain this any further, what I can do is to accept it under the https://github.com/redis-rb/ org, and look for new maintainers.

Ah I don't see any comments so I'm a bit confused.

BTW I needed the gem to work with 5.0 so I quickly updated it here: https://github.com/urmilkalaria/rejson-rb/compare/master...tinco:rejson-rb:main

I only made it pass the specs. There's actually some deeper upgrades needed to match the main gem's newer API style that I didn't start on.

@tinco I can transfer this project to you if you want to maintain this?

I'm not a very dependable person at the moment. I'm using rejson for a project in my free time, my day job is super busy and I also have a baby. If I'm still using rejson in a month or two and I feel like making it more production grade I'll send you a message. At the moment I don't have the time to make something I would feel comfortable with encouraging other people to run in production.