coreutils icon indicating copy to clipboard operation
coreutils copied to clipboard

Published 20 hours ago • verified publisher icon uutils

cksum: implement check

Open sylvestre opened this issue 1 year ago • 13 comments

sylvestre avatar May 09 '24 20:05 sylvestre

GNU testsuite comparison:

GNU test failed: tests/cksum/cksum-a. tests/cksum/cksum-a is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/cksum/cksum-c is no longer failing!

github-actions[bot] avatar May 10 '24 07:05 github-actions[bot]

GNU testsuite comparison:

GNU test failed: tests/cksum/cksum-a. tests/cksum/cksum-a is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/cksum/cksum-c is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar May 10 '24 08:05 github-actions[bot]

should fail but getting close

sylvestre avatar May 11 '24 07:05 sylvestre

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar May 11 '24 07:05 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-c is no longer failing!

github-actions[bot] avatar May 12 '24 09:05 github-actions[bot]

https://github.com/coreutils/coreutils/commit/b5ce9fb177b87e20c51f062e466b46b5283d02e9 I contributed this upstream as they were missing

sylvestre avatar May 12 '24 11:05 sylvestre

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-c is no longer failing!

github-actions[bot] avatar May 12 '24 15:05 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-c is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar May 12 '24 19:05 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-c is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar May 12 '24 20:05 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-c is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar May 12 '24 21:05 github-actions[bot]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar May 14 '24 17:05 github-actions[bot]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar May 14 '24 21:05 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-c is no longer failing!

github-actions[bot] avatar May 15 '24 10:05 github-actions[bot]

@BenWiederhake I added tests on our side (ignored) for stuff that we don't support yet (and probably quite niche) As GNU doesn't have tests either, i proposed that we land this PR + i will contribute these tests upstream. thanks!

sylvestre avatar May 15 '24 20:05 sylvestre

Done :)

inconsistent behavior caused by the inclusion of b in the algo-name regex: fixed too

sylvestre avatar May 17 '24 20:05 sylvestre

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-c is no longer failing!

github-actions[bot] avatar May 17 '24 20:05 github-actions[bot]

Remaining failures seem to be the usual (#6275, #6333, and that new "year 1677" thing on mac), so it's as green as it can be, currently.

BenWiederhake avatar May 18 '24 21:05 BenWiederhake