uno
uno copied to clipboard
Published
20 hours ago •
unoplatform
unoplatform
fix(MenyFlyoutPresenter): Fix TemplatedParent propagation in MenuFlyoutPresenter
GitHub Issue (If applicable): closes https://github.com/unoplatform/uno/issues/1884
PR Type
What kind of change does this PR introduce?
- Bugfix
What is the new behavior?
Manually propagates the TemplatedParent to the children of MenuFlyoutPresenter
PR Checklist
Please check if your PR fulfills the following requirements:
- [ ] Docs have been added/updated which fit documentation template (for bug fixes / features)
- [ ] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
- [ ] Validated PR
Screenshots Compare Test Runresults. - [ ] Contains NO breaking changes
- [ ] Associated with an issue (GitHub or internal) and uses the automatic close keywords.
- [ ] Commits must be following the Conventional Commits specification.
Other information
Internal Issue (If applicable):
![gitpod-io[bot] avatar](https://avatars.githubusercontent.com/in/23396?v=4 "Published by a pub.dev verified publisher"){kind=small}
The build 51759 found UI Test snapshots differences: android-28-xamarin: 21, android-28-xamarin-Snap: 999, ios: 46, ios-Snap: 85, macOS-screenshots: 36, skia-gtk-screenshots: 9, skia-wpf-screenshots: 8, wasm: 19, wasm-automated-net5.0-Benchmarks: 0, wasm-automated-net5.0-Default: 10, wasm-automated-net5.0-RuntimeTests: 0
Details
-
android-28-xamarin: 21 changed over 850🚨🚨 Comparison Details (first 20) 🚨🚨
FocusManager_GetFocusedElement_ComboBoxItem_LostFocus_Validation_FocusManager_-_LostFocus_-_ComboBoxItem_-_1_-_Initial_StateFocusManager_GetFocusedElement_ComboBoxItem_LostFocus_Validation_FocusManager_-_LostFocus_-_ComboBoxItem_-_2_-_Click_outsideFocusManager_GetFocusedElement_ComboBoxItem_LostFocus_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_AutomatedCommandBar_LongTitle_Validation_CommandBar_-_LongTitle_-_3_-_Orientation_PortraitFocusManager_GetFocusedElement_TextBoxMultiLine_Validation_FocusManager_-_GetFocusedElement_-_TextBoxMultiLine_-_2_-_After_SelectionKeyboard_Textbox_NoScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBoxProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPageTestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_FeaturesWhen_Click_Outside_Dialog_Expect_No_Dismiss_AfterClickingWhen_Click_Outside_Dialog_Expect_No_Dismiss_BeforeClickingTimePicker_Header_UITests_Windows_UI_Xaml_Controls_TimePicker_TimePicker_HeaderToggleCollapsedStateToVerifyClipping_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_ExpanderColorValidationPageWhen_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewerWhen_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touchWebView_NavigateToAnchor_click_anchorWebView_NavigateToAnchor_navigate_to_anchorWebView_NavigateToLongString_AfterSuccessWhen_InScrollViewer_after_scroll
-
android-28-xamarin-Snap: 999 changed over 1000🚨🚨 Comparison Details (first 20) 🚨🚨
Animations_DoubleAnimationUsingKeyFrames_TranslateX_GenericApp_Views_Content_UITests_Animations_DoubleAnimationUsingKeyFrames_TranslateXAnimations_DoubleAnimation_Opacity_TextBlock_GenericApp_Views_Content_UITests_Animations_DoubleAnimation_Opacity_TextBlockAnimations_DoubleAnimation_TranslateX_GenericApp_Views_Content_UITests_Animations_DoubleAnimation_TranslateXAnimations_UITests_Windows_UI_Xaml_Media_Animation_ColorAnimation_Background_UITests_Windows_UI_Xaml_Media_Animation_ColorAnimation_BackgroundAutomation_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_NameAutoSuggestBox_UITests_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_Reason_UITests_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_ReasonBorder_AutoBorderStretchwithtopmargin_Uno_UI_Samples_UITests_BorderTestsControl_AutoBorderStretchwithtopmarginBorder_BorderCenteredwithmargins_Uno_UI_Samples_UITests_BorderTestsControl_BorderCenteredwithmarginsBorder_Border_CornerRadius_Alignments_Uno_UI_Samples_UITests_BorderTestsControl_Border_CornerRadius_AlignmentsBorder_Border_CornerRadius_Binding_Uno_UI_Samples_UITests_BorderTestsControl_Border_CornerRadius_BindingBorder_Border_Simple_No_Background_With_Content_Border_With_Background_Uno_UI_Samples_UITests_BorderTestsControl_Border_Simple_No_Background_With_Content_Border_With_BackgroundBorder_Border_Simple_No_Background_With_TextBox_Uno_UI_Samples_UITests_BorderTestsControl_Border_Simple_No_Background_With_TextBoxBorder_OnepxThicknessandRadiusAndTextBlock_Uno_UI_Samples_UITests_BorderTestsControl_OnepxThicknessandRadiusAndTextBlockBorder_OnepxThicknessandRadius_Uno_UI_Samples_UITests_BorderTestsControl_OnepxThicknessandRadiusBorder_Uniform_Thickness_and_Large_Radius_Uno_UI_Samples_UITests_BorderTestsControl_Uniform_Thickness_and_Large_RadiusBorder_Uniform_Thickness_and_Small_Radius_Uno_UI_Samples_UITests_BorderTestsControl_Uniform_Thickness_and_Small_RadiusBrushes_BorderImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_BorderImageBrushBrushes_EllipsemaskingEllipseGrid_Uno_UI_Samples_UITests_ImageBrushTestControl_EllipsemaskingEllipseGridBrushes_ImageBrushStretch2_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch2Brushes_ImageBrushStretch_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch
-
ios: 46 changed over 296🚨🚨 Comparison Details (first 20) 🚨🚨
Keyboard_Textbox_NoScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBoxListView_ObservableCollection_Creation_Count_AddedListView_ObservableCollection_Unused_Space_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_ObservableCollection_Unused_SpaceListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItemsScreenshots_Image_Stretch_Alignment_Bigger_Mode-2Screenshots_Image_Stretch_Alignment_Bigger_Mode-3Screenshots_Image_Stretch_Alignment_Equal_Mode-0Screenshots_Image_Stretch_Alignment_Equal_Mode-1Screenshots_Image_Stretch_Alignment_Taller_Mode-2Screenshots_Image_Stretch_Alignment_Taller_Mode-3Screenshots_Image_Stretch_Alignment_Wider_Mode-0Screenshots_Image_Stretch_Alignment_Wider_Mode-1Flyout_ShowAt_Window_Content_UITests_Windows_UI_Xaml_Controls_FlyoutTests_Flyout_ShowAt_Window_ContentKeyboard_Textbox_NoScrollViewer_Validation_1_-_Remove_Focus_on_filledTextBoxListView_ObservableCollection_Creation_Count_Added_aboveListView_ObservableCollection_Creation_Count_Removed_aboveListView_ObservableCollection_Creation_Count_Scrolled1ListView_ObservableCollection_Creation_Count_Scrolled2ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
-
ios-Snap: 85 changed over 991🚨🚨 Comparison Details (first 20) 🚨🚨
Automation_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_NameBorder_BorderCenteredwithmargins_Uno_UI_Samples_UITests_BorderTestsControl_BorderCenteredwithmarginsBorder_Border_Simple_with_Opacity_Uno_UI_Samples_UITests_BorderTestsControl_Border_Simple_with_OpacityBrushes_ImageBrushWithCompositeTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithCompositeTransformBrushes_UITests_Shared_Windows_UI_Xaml_Media_ImageBrushTests_ImageBrush_SameWithDelay_UITests_Shared_Windows_UI_Xaml_Media_ImageBrushTests_ImageBrush_SameWithDelayBrushes_UITests_Windows_UI_Xaml_Media_BrushesTests_Brushes_ImplicitConvert_UITests_Windows_UI_Xaml_Media_BrushesTests_Brushes_ImplicitConvertButtons_Simple_TextBlockButton_Uno_UI_Samples_Content_UITests_TextBlockControl_Simple_TextBlockButtonAnimations_UITests_Windows_UI_Xaml_Media_Animation_FadeInOutThemeAnimationPage_UITests_Windows_UI_Xaml_Media_Animation_FadeInOutThemeAnimationPageAutoSuggestBox_UITests_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_BitmapIcon_UITests_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_BitmapIconBorder_AutoBorderStretchwithtopmargin_Uno_UI_Samples_UITests_BorderTestsControl_AutoBorderStretchwithtopmarginBorder_Border_Simple_with_non_Uniform_Thickness_Uno_UI_Samples_UITests_BorderTestsControl_Border_Simple_with_non_Uniform_ThicknessBorder_Uno_UI_Samples_UITests_BorderTestsControl_Border_BorderThickness_Uno_UI_Samples_UITests_BorderTestsControl_Border_BorderThicknessClipping_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClippingContentPresenter_ContentPresenter_Background_Uno_UI_Samples_Content_UITests_ContentPresenter_ContentPresenter_BackgroundAnimations_UITests_Windows_UI_Xaml_Media_Animation_ColorAnimation_Background_UITests_Windows_UI_Xaml_Media_Animation_ColorAnimation_BackgroundAutoSuggestBox_UITests_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_Icons_UITests_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_IconsBorder_AutoBorderStretchwithleftmargin_Uno_UI_Samples_UITests_BorderTestsControl_AutoBorderStretchwithleftmarginBorder_BorderRightwithmargins_Uno_UI_Samples_UITests_BorderTestsControl_BorderRightwithmarginsButtons_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Custom_Button_With_ContentTemplate_And_StackPanel_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Custom_Button_With_ContentTemplate_And_StackPanelContentControl_ContentControl_Nested_TemplatedParent_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_Nested_TemplatedParent
-
macOS-screenshots: 36 changed over 1064🚨🚨 Comparison Details (first 20) 🚨🚨
BreadcrumbBar-BreadcrumbBarPage.pngColorPicker-WinUIColorPickerPage.pngItemsRepeater-UniformGridLayout_Simple.pngExpander-ExpanderColorValidationPage.pngImage-Image_Stretch_Alignment_SizeOnControl.pngGesture Recognizer-Pointer Events test bench.pngImage-Image_Formats.pngListView-ListView_With_ListViews_Count_Measure.pngMUX-NavigationViewCompactPaneLengthTestPage.pngMUX-NavigationViewCustomThemeResourcesPage.pngMUX-WinUIProgressBarPage.pngMUX-WinUIProgressRingPage.pngMUX-WinUIProgressRing_CustomSources.pngNavigationView-NavigationViewTopNavOnlyPage.pngNavigationView-NavigationViewTopNavPage.pngPagerControl-PagerControlPage.pngImage-Image_Stretch_None_ScrollViewer.pngMUX-NavigationViewPage.pngMUX-NavigationViewRS3Page.pngMUX-NavigationViewTopNavOnlyPage.png
-
skia-gtk-screenshots: 9 changed over 1051🚨🚨 Comparison Details (first 20) 🚨🚨
Brushes-ImageBrush_StreamSource.pngProgress-WindowsProgressRing_GH1220.pngProgress-WinUIProgressRingPage.pngMUX-TabViewPage.pngMUX-WinUIProgressRingPage.pngMUX-WinUIProgressRing_CustomSources.pngProgress-WinUIProgressRing_CustomSources.pngProgress-WinUIProgressRing_Features.pngTabView-TabViewPage.png
-
skia-wpf-screenshots: 8 changed over 1051🚨🚨 Comparison Details (first 20) 🚨🚨
Automation-AutomationProperties_Name.pngMUX-WinUIProgressRingPage.pngMUX-WinUIProgressRing_CustomSources.pngMUX-ColorPickerSample.pngProgress-WinUIProgressRing_CustomSources.pngProgress-WinUIProgressRing_Features.pngProgress-WindowsProgressRing_GH1220.pngProgress-WinUIProgressRingPage.png
-
wasm: 19 changed over 999🚨🚨 Comparison Details (first 20) 🚨🚨
SamplesApp.Wasm.Windows_UI_Xaml_Controls.ListView.ListView_IsSelectedUITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRingPageUITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRing_FeaturesUITests.Shared.Windows_UI_Xaml_Controls.ImageTests.Image_Stretch_Alignment_SizeOnControlUITests.Microsoft_UI_Xaml_Controls.ColorPickerTests.ColorPickerSampleUITests.Shared.Windows_UI_Xaml_Automation.AutomationProperties_NameUITests.Shared.Windows_UI_Xaml_Controls.ImageTests.Image_Stretch_Algmnt_Inf_HorizontalUITests.Shared.Windows_UI_Xaml_Controls.ImageTests.Image_Stretch_Algmnt_Inf_VerticalUITests.Windows_UI_Xaml_Shapes.Offscreen_ShapesUITests.Windows_UI_Xaml_Controls.ProgressRing.WindowsProgressRing_GH1220UITests.Uno_Web.Http.CookieManagerTestsUITests.Windows_UI_Xaml.WindowTests.Window_SetBackgroundUITests.Windows_UI_Xaml.DragAndDrop.DragDrop_TestPageUno.UI.Samples.Content.UITests.TextBlockControl.TextBlockMultilineInStarStackPanelUno.UI.Samples.Content.UITests.TextBlockControl.TextBoxSizeChangingUno.UI.Samples.Content.UITests.TextBlockControl.TextBlock_FixedWidth_With_DataBound_RunUno.UI.Samples.UITests.Image.Image_Stretch_Alignment_TallerUno.UI.Samples.UITests.ImageBrushTestControl.EllipseUno.UI.Samples.Samples.Shared.Content.UITests.ImageBrushInList
-
wasm-automated-net5.0-Benchmarks: 0 changed over 1 -
wasm-automated-net5.0-Default: 10 changed over 877🚨🚨 Comparison Details (first 20) 🚨🚨
DatePicker_Flyout_DatePicker_-_FlyoutImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_NoneListView_Weird_Measure_During_Arrange_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_Weird_MeasureSequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPageTestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_FeaturesNavigationView_OnLightDismiss_TogglePaneButton_IsSizedCorrectly_SamplesApp_Samples_NavigationViewSample_NavigationViewSampleScreenshots_Image_Stretch_Alignment_Bigger_Mode-0When_PressOnContainerAndReleaseOnNested_Mouse_UITests_Windows_UI_Input_PointersTests_Nested_SequenceValidate_Offscreen_Shapes_UITests_Windows_UI_Xaml_Shapes_Offscreen_ShapesWhen_TransformToVisual_ScrollViewer_UITests_Shared_Windows_UI_Xaml_UIElementTests_TransformToVisual_ScrollViewer
-
wasm-automated-net5.0-RuntimeTests: 0 changed over 1
