uno icon indicating copy to clipboard operation
uno copied to clipboard

fix(ios): border + corner rendering

Open Xiaoy312 opened this issue 3 years ago • 1 comments
trafficstars

GitHub Issue (If applicable): closes #9208

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

iOS border can only be drawn with perfect circles, not ellipses.

What is the new behavior?

iOS border should support most of the scenarios.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

re: #6891

Internal Issue (If applicable):

Xiaoy312 avatar Aug 09 '22 14:08 Xiaoy312

gitpod-io[bot] avatar Aug 09 '22 14:08 gitpod-io[bot]

edit0812: undone renaming to make diff cleaner for now edit0812: fixed issue with even-odd fill rule screenshots look good edit0815: converted LayoutState to record

Xiaoy312 avatar Aug 12 '22 19:08 Xiaoy312

The build 51889 found UI Test snapshots differences: android-28-xamarin: 16, android-28-xamarin-Snap: 22, ios: 38, ios-Snap: 210, macOS-screenshots: 126, skia-gtk-screenshots: 8, skia-wpf-screenshots: 9, wasm: 19, wasm-automated-net5.0-Benchmarks: 0, wasm-automated-net5.0-Default: 4, wasm-automated-net5.0-RuntimeTests: 0

Details
  • android-28-xamarin: 16 changed over 850

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • FocusManager_GetFocusedElement_TextBoxMultiLine_LostFocus_Validation_FocusManager_-_LostFocus_-_TextBoxMultiLine_-_2_-_Click_outside
    • FocusManager_GetFocusedElement_TextBoxMultiLine_Validation_FocusManager_-_GetFocusedElement_-_TextBoxMultiLine_-_2_-_After_Selection
    • ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
    • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • TimePicker_Header_UITests_Windows_UI_Xaml_Controls_TimePicker_TimePicker_Header
    • When_Click_Outside_Dialog_Expect_No_Dismiss_AfterClicking
    • When_Click_Outside_Dialog_Expect_No_Dismiss_BeforeClicking
    • TestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
    • WebView_NavigateToAnchor_click_anchor
    • WebView_NavigateToAnchor_navigate_to_anchor
    • When_InScrollViewer_after_scroll
    • When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer
    • When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch
    • When_TransformToVisual_ScrollViewer_UITests_Shared_Windows_UI_Xaml_UIElementTests_TransformToVisual_ScrollViewer
  • android-28-xamarin-Snap: 22 changed over 1000

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Buttons_Custom_Button_With_ContentTemplate_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Custom_Button_With_ContentTemplate
    • ColorPicker_ColorPickerSample_UITests_Microsoft_UI_Xaml_Controls_ColorPickerTests_ColorPickerSample
    • ComboBox_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_DropDownPlacement_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_DropDownPlacement
    • ComboBox_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_VisibleBounds_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_VisibleBounds
    • ContentControl_ContentControl_Nested_TemplatedParent_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_Nested_TemplatedParent
    • Grid_CenteredGridinGridwiththreefixedsizechildren_Uno_UI_Samples_Content_UITests_GridTestsControl_CenteredGridinGridwiththreefixedsizechildren
    • Mapping_MapControl_Uno_UI_Samples_Content_UITests_MapControl_MapControl
    • NavigationView_FluentStyle_NavigationViewSample_SamplesApp_Samples_Microsoft_UI_Xaml_Controls_NavigationViewTests_FluentStyle_FluentStyle_NavigationViewSample
    • Pickers_TimePicker_TimePickerFlyoutStyle_UITests_Windows_UI_Xaml_Controls_TimePicker_TimePicker_TimePickerFlyoutStyle
    • Pickers_UITests_Windows_UI_Xaml_Controls_TimePicker_TimePicker_Header_UITests_Windows_UI_Xaml_Controls_TimePicker_TimePicker_Header
    • Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressBar_WinUIProgressBarSimple_UITests_Microsoft_UI_Xaml_Controls_ProgressBar_WinUIProgressBarSimple
    • Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage
    • Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_CustomSources_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_CustomSources
    • Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
    • Progress_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • TextBlock_TextBoxSizeChanging_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBoxSizeChanging
    • TextBlock_TextBlockMultilineInStarStackPanel_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlockMultilineInStarStackPanel
    • TextBlock_TextBlock_FixedWidth_With_DataBound_Run_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_FixedWidth_With_DataBound_Run
    • TextBox_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_Reveal_Scroll_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_Reveal_Scroll
    • WebView_WebView_JavascriptInvoke_Uno_UI_Samples_Content_UITests_WebView_WebView_JavascriptInvoke
  • ios: 38 changed over 296

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Border_CornerRadius_BorderThickness_Border-CornerRadius-10-BorderThickness-10_0_0_10
    • Border_CornerRadius_BorderThickness_Border-CornerRadius-10-BorderThickness-10_10_10_10
    • Border_CornerRadius_Clipping_Screenshot
    • Border_CornerRadius_GradientBrush_Screenshot
    • Change_Manipulation_Property_After_property_change
    • Change_Manipulation_Property_Before_property_change
    • ContentPresenter_Template_Uno_UI_Samples_Content_UITests_ContentPresenter_ContentPresenter_Template
    • DatePicker_Flyout_DatePicker_-_Flyout
    • Keyboard_Textbox_NoScrollViewer_Validation_2_-_Remove_Focus_on_placeholderTextTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_4_-_Remove_Focus_on_multilineTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox
    • Border_CornerRadius_BorderThickness_Border-CornerRadius-10-BorderThickness-10_0_0_0
    • Border_CornerRadius_BorderThickness_Border-CornerRadius-10-BorderThickness-10_0_10_10
    • Border_CornerRadius_Clipping_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_Clipping
    • Border_CornerRadius_GradientBrush_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_Gradient
    • Change_Manipulation_Property_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_Clipped_Change_Property
    • Check_CornerRadius_Border_Basic_sample
    • Check_CornerRadius_Border_CornerRadius=5
    • Keyboard_Textbox_NoScrollViewer_Validation_0_-_Remove_Focus_on_normalTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_1_-_Remove_Focus_on_filledTextBox
  • ios-Snap: 210 changed over 991

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Animations_DoubleAnimation_TranslateX_GenericApp_Views_Content_UITests_Animations_DoubleAnimation_TranslateX
    • Animations_UITests_Windows_UI_Xaml_Media_Animation_ColorAnimation_Background_UITests_Windows_UI_Xaml_Media_Animation_ColorAnimation_Background
    • AutoSuggestBox_UITests_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_Reason_UITests_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_Reason
    • Border_BorderRightwithmargins_Uno_UI_Samples_UITests_BorderTestsControl_BorderRightwithmargins
    • Border_BorderTopwithmargins_Uno_UI_Samples_UITests_BorderTestsControl_BorderTopwithmargins
    • Border_Border_CornerRadius_Uno_UI_Samples_UITests_BorderTestsControl_Border_CornerRadius
    • Border_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_Clipped_Change_Property_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_Clipped_Change_Property
    • Border_Uno_UI_Samples_UITests_BorderTestsControl_Border_BorderThickness_Uno_UI_Samples_UITests_BorderTestsControl_Border_BorderThickness
    • Brushes_BorderImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_BorderImageBrush
    • Brushes_EllipsemaskingEllipseGrid_Uno_UI_Samples_UITests_ImageBrushTestControl_EllipsemaskingEllipseGrid
    • Brushes_ImageBrushLocalAsset_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushLocalAsset
    • Brushes_ImageBrushStretch_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch
    • Brushes_PanelImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_PanelImageBrush
    • Brushes_PathImageBrushfill_Uno_UI_Samples_UITests_ImageBrushTestControl_PathImageBrushfill
    • Brushes_UITests_Windows_UI_Xaml_Media_BrushesTests_SolidColorBrush_Color_Changed_UITests_Windows_UI_Xaml_Media_BrushesTests_SolidColorBrush_Color_Changed
    • Brushes_UITests_Windows_UI_Xaml_Media_GradientBrushTests_GradientsPage_UITests_Windows_UI_Xaml_Media_GradientBrushTests_GradientsPage
    • Brushes_UITests_Windows_UI_Xaml_Media_GradientBrushTests_LinearGradientBrush_Change_Stops_UITests_Windows_UI_Xaml_Media_GradientBrushTests_LinearGradientBrush_Change_Stops
    • Brushes_Uno_UI_Samples_UITests_ImageBrushTestControl_Ellipse_Uno_UI_Samples_UITests_ImageBrushTestControl_Ellipse
    • Brushes_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrush_StreamSource_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrush_StreamSource
    • Buttons_Buttons_Native_UITests_Shared_Windows_UI_Xaml_Controls_Buttons_Native
  • macOS-screenshots: 126 changed over 1064

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Border-Border_AntiAlias.png
    • Border-Border_Clipped_Change_Property.png
    • Border-Border_CornerRadius.png
    • Border-Border_CornerRadius_Alignments.png
    • Border-Border_CornerRadius_Clipping.png
    • Border-Border_CornerRadius_Gradient.png
    • Border-Border_LinearGradientBrush.png
    • Border-Circle.png
    • Border-NonUniformThicknessandRadius.png
    • Border-OnepxThicknessandRadius.png
    • Border-OnepxThicknessandRadiusAndTextBlock.png
    • Border-UniformThicknessandNonUniformRadius.png
    • Border-Uniform_Thickness_and_Large_Radius.png
    • Border-Uniform_Thickness_and_Small_Radius.png
    • BreadcrumbBar-BreadcrumbBarPage.png
    • Brushes-BorderImageBrush.png
    • Brushes-DynamicBrushes_On_Shapes.png
    • Brushes-Ellipse.png
    • Brushes-GradientsPage.png
    • Brushes-ImageBrushAlignmentXY.png
  • skia-gtk-screenshots: 8 changed over 1051

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Brushes-EllipsemaskingEllipseSuperpositionPanel.png
    • ColorPicker-WinUIColorPickerPage.png
    • MUX-WinUIProgressRingPage.png
    • MUX-WinUIProgressRing_CustomSources.png
    • Progress-WindowsProgressRing_GH1220.png
    • Progress-WinUIProgressRingPage.png
    • Progress-WinUIProgressRing_CustomSources.png
    • Progress-WinUIProgressRing_Features.png
  • skia-wpf-screenshots: 9 changed over 1051

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Automation-AutomationProperties_Name.png
    • Brushes-Ellipse.png
    • Image-Image_Stretch_None_ScrollViewer.png
    • MUX-WinUIProgressRingPage.png
    • MUX-WinUIProgressRing_CustomSources.png
    • Progress-WindowsProgressRing_GH1220.png
    • Progress-WinUIProgressRingPage.png
    • Progress-WinUIProgressRing_CustomSources.png
    • Progress-WinUIProgressRing_Features.png
  • wasm: 19 changed over 999

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ListView.ListView_IsSelected
    • UITests.Microsoft_UI_Xaml_Controls.ColorPickerTests.ColorPickerSample
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRingPage
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRing_Features
    • UITests.Shared.Windows_UI_Xaml_Controls.ImageTests.Image_Stretch_Algmnt_Inf_Horizontal
    • UITests.Shared.Windows_UI_Xaml_Automation.AutomationProperties_Name
    • UITests.Shared.Windows_UI_Xaml_Controls.ImageTests.Image_Stretch_Alignment_SizeOnControl
    • UITests.Toolkit.ElevatedView_CornerRadius
    • UITests.Uno_Web.Http.CookieManagerTests
    • UITests.Windows_UI_Xaml.DragAndDrop.DragDrop_TestPage
    • UITests.Windows_UI_Xaml.WindowTests.Window_SetBackground
    • UITests.Windows_UI_Xaml_Controls.ProgressRing.WindowsProgressRing_GH1220
    • Uno.UI.Samples.Content.UITests.TextBlockControl.TextBoxSizeChanging
    • Uno.UI.Samples.Content.UITests.TextBlockControl.TextBlockMultilineInStarStackPanel
    • Uno.UI.Samples.Content.UITests.TextBlockControl.TextBlock_FixedWidth_With_DataBound_Run
    • Uno.UI.Samples.UITests.Image.Image_Stretch_Alignment_Equal
    • Uno.UI.Samples.UITests.Image.Image_Stretch_Alignment_Smaller
    • Uno.UI.Samples.UITests.Image.Image_Stretch_Alignment_Taller
    • Uno.UI.Samples.UITests.ImageBrushTestControl.Ellipse
  • wasm-automated-net5.0-Benchmarks: 0 changed over 1

  • wasm-automated-net5.0-Default: 4 changed over 877

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
    • ListView_Weird_Measure_During_Arrange_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_Weird_Measure
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • TestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
  • wasm-automated-net5.0-RuntimeTests: 0 changed over 1

nventive-devops avatar Aug 13 '22 02:08 nventive-devops

The build 51976 found UI Test snapshots differences: android-28-xamarin: 23, android-28-xamarin-Snap: 999, ios: 61, ios-Snap: 165, macOS-screenshots: 122, skia-gtk-screenshots: 13, skia-wpf-screenshots: 9, wasm: 17, wasm-automated-net5.0-Benchmarks: 0, wasm-automated-net5.0-Default: 8, wasm-automated-net5.0-RuntimeTests: 0

Details
  • android-28-xamarin: 23 changed over 850

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • CommandBar_LongTitle_Validation_CommandBar_-_LongTitle_-_4_-_Orientation_Landscape
    • FocusManager_GetFocusedElement_CheckBox_Validation_FocusManager_-_GetFocusedElement_-_CheckBox_-_1_-_Initial_State
    • FocusManager_GetFocusedElement_CheckBox_Validation_FocusManager_-_GetFocusedElement_-_CheckBox_-_2_-_After_Selection
    • FocusManager_GetFocusedElement_CheckBox_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated
    • FocusManager_GetFocusedElement_TextBoxMultiLine_Validation_FocusManager_-_GetFocusedElement_-_TextBoxMultiLine_-_2_-_After_Selection
    • Keyboard_Textbox_NoScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox
    • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • TestManipulation_Result
    • TestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
    • TimePicker_Header_UITests_Windows_UI_Xaml_Controls_TimePicker_TimePicker_Header
    • ToggleCollapsedStateToVerifyClipping_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_ExpanderColorValidationPage
    • WebView_NavigateToAnchor_click_anchor
    • WebView_NavigateToAnchor_Initial
    • WebView_NavigateToAnchor_navigate_to_anchor
    • WebView_NavigateToLongString_AfterSuccess
    • When_Click_Outside_Dialog_Expect_No_Dismiss_AfterClicking
    • When_Click_Outside_Dialog_Expect_No_Dismiss_BeforeClicking
    • When_InScrollViewer_after_scroll
  • android-28-xamarin-Snap: 999 changed over 1001

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Animations_DoubleAnimationTestsControl_Uno_UI_Samples_Content_UITests_DoubleAnimationTestsControl
    • Animations_DoubleAnimation_BeginTime_Uno_UI_Samples_Content_UITests_Animations_DoubleAnimation_BeginTime
    • Animations_DoubleAnimation_Opacity_TextBlock_GenericApp_Views_Content_UITests_Animations_DoubleAnimation_Opacity_TextBlock
    • Animations_DoubleAnimation_RenderTransformOrigin_GenericApp_Views_Content_UITests_Animations_DoubleAnimation_RenderTransformOrigin
    • Animations_DoubleAnimation_TranslateX_GenericApp_Views_Content_UITests_Animations_DoubleAnimation_TranslateX
    • Animations_DoubleAnimation_VisualStates_Uno_UI_Samples_Content_UITests_Animations_DoubleAnimation_VisualStates
    • Animations_UITests_Windows_UI_Xaml_Media_Animation_ColorAnimationUsingKeyFrames_Fill_UITests_Windows_UI_Xaml_Media_Animation_ColorAnimationUsingKeyFrames_Fill
    • Animations_UITests_Windows_UI_Xaml_Media_Animation_ColorAnimation_Fill_UITests_Windows_UI_Xaml_Media_Animation_ColorAnimation_Fill
    • Automation_AutomationProperties_AutomationId_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_AutomationId
    • Automation_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name
    • AutoSuggestBox_UITests_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_Description_UITests_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_Description
    • AutoSuggestBox_UITests_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_Icons_UITests_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_Icons
    • Border_AutoBorderStretchwithleftmargin_Uno_UI_Samples_UITests_BorderTestsControl_AutoBorderStretchwithleftmargin
    • Border_AutoBorderStretchwithrightmargin_Uno_UI_Samples_UITests_BorderTestsControl_AutoBorderStretchwithrightmargin
    • Border_BorderCenteredwithmargins_Uno_UI_Samples_UITests_BorderTestsControl_BorderCenteredwithmargins
    • Border_BorderLeftwithmargins_Uno_UI_Samples_UITests_BorderTestsControl_BorderLeftwithmargins
    • Border_Border_AntiAlias_UITests_Windows_UI_Xaml_Controls_BorderTests_BorderAntiAlias
    • Border_Border_CornerRadius_Alignments_Uno_UI_Samples_UITests_BorderTestsControl_Border_CornerRadius_Alignments
    • Border_Border_CornerRadius_Clipping_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_Clipping
    • Border_Border_CornerRadius_Gradient_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_Gradient
  • ios: 61 changed over 296

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Border_CornerRadius_BorderThickness_Border-CornerRadius-10-BorderThickness-10_0_0_0
    • Border_CornerRadius_BorderThickness_Border-CornerRadius-10-BorderThickness-10_0_0_10
    • Border_CornerRadius_BorderThickness_Border-CornerRadius-10-BorderThickness-10_0_10_10
    • Border_CornerRadius_BorderThickness_Border-CornerRadius-10-BorderThickness-10_10_10_10
    • Border_CornerRadius_Clipping_Screenshot
    • Border_CornerRadius_Clipping_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_Clipping
    • Border_CornerRadius_GradientBrush_Screenshot
    • Border_CornerRadius_GradientBrush_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_Gradient
    • Change_Manipulation_Property_After_property_change
    • Change_Manipulation_Property_Before_property_change
    • Change_Manipulation_Property_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_Clipped_Change_Property
    • Check_CornerRadius_Border_Basic_sample
    • Check_CornerRadius_Border_CornerRadius=5
    • DatePicker_Flyout_DatePicker_-_Flyout
    • Flyout_ShowAt_Window_Content_UITests_Windows_UI_Xaml_Controls_FlyoutTests_Flyout_ShowAt_Window_Content
    • Keyboard_Textbox_NoScrollViewer_Validation_4_-_Remove_Focus_on_multilineTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_0_-_Remove_Focus_on_normalTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_1_-_Remove_Focus_on_filledTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_2_-_Remove_Focus_on_placeholderTextTextBox
  • ios-Snap: 165 changed over 992

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Animations_DoubleAnimation_TranslateX_GenericApp_Views_Content_UITests_Animations_DoubleAnimation_TranslateX
    • Automation_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name
    • Border_AutoBorderStretchwithleftmargin_Uno_UI_Samples_UITests_BorderTestsControl_AutoBorderStretchwithleftmargin
    • Border_Border_AntiAlias_UITests_Windows_UI_Xaml_Controls_BorderTests_BorderAntiAlias
    • Border_Border_CornerRadius_Alignments_Uno_UI_Samples_UITests_BorderTestsControl_Border_CornerRadius_Alignments
    • Border_Border_CornerRadius_Clipping_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_Clipping
    • Border_Border_CornerRadius_Gradient_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_Gradient
    • Border_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_Clipped_Change_Property_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_Clipped_Change_Property
    • Brushes_ImageBrushAlignmentXY_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushAlignmentXY
    • Brushes_ImageBrushChangingCornerRadius_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushChangingCornerRadius
    • Brushes_ImageBrushWithCompositeTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithCompositeTransform
    • Brushes_ImageBrushWithLateSource_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithLateSource
    • Brushes_PanelImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_PanelImageBrush
    • Brushes_PathImageBrushfill_Uno_UI_Samples_UITests_ImageBrushTestControl_PathImageBrushfill
    • Brushes_UITests_Windows_UI_Xaml_Media_BrushesTests_SolidColorBrush_Color_Changed_UITests_Windows_UI_Xaml_Media_BrushesTests_SolidColorBrush_Color_Changed
    • Brushes_UITests_Windows_UI_Xaml_Media_GradientBrushTests_GradientsPage_UITests_Windows_UI_Xaml_Media_GradientBrushTests_GradientsPage
    • Brushes_UITests_Windows_UI_Xaml_Media_GradientBrushTests_LinearGradientBrush_Change_Stops_UITests_Windows_UI_Xaml_Media_GradientBrushTests_LinearGradientBrush_Change_Stops
    • Brushes_Uno_UI_Samples_UITests_ImageBrushTestControl_Ellipse_Uno_UI_Samples_UITests_ImageBrushTestControl_Ellipse
    • Brushes_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrush_StreamSource_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrush_StreamSource
    • Buttons_AppBarToggleButtonTest_Uno_UI_Samples_Content_UITests_ButtonTestsControl_AppBarToggleButtonTest
  • macOS-screenshots: 122 changed over 1065

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Border-Border_AntiAlias.png
    • Border-Border_CornerRadius.png
    • Border-Border_CornerRadius_Alignments.png
    • Border-Border_CornerRadius_Clipping.png
    • Border-Border_CornerRadius_Gradient.png
    • Border-Border_LinearGradientBrush.png
    • Border-NonUniformThicknessandRadius.png
    • Border-OnepxThicknessandRadius.png
    • Border-OnepxThicknessandRadiusAndTextBlock.png
    • Brushes-DynamicBrushes_On_Shapes.png
    • Brushes-Ellipse.png
    • Brushes-GradientsPage.png
    • Brushes-ImageBrushAlignmentXY.png
    • Brushes-ImageBrushChangingCornerRadius.png
    • Brushes-SolidColorBrush_Color_Changed.png
    • Animations-BeginTime_MultipleAnimations.png
    • Border-Border_Clipped_Change_Property.png
    • Border-Circle.png
    • Border-UniformThicknessandNonUniformRadius.png
    • Border-Uniform_Thickness_and_Large_Radius.png
  • skia-gtk-screenshots: 13 changed over 1052

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Brushes-Ellipse.png
    • Brushes-ImageBrushChangingCornerRadius.png
    • DragAndDrop-DragDrop_TestPage.png
    • Image-UniformToFill100x100.png
    • Image-Image_Stretch.png
    • MUX-WinUIProgressRingPage.png
    • MUX-WinUIProgressRing_CustomSources.png
    • Progress-WindowsProgressRing_GH1220.png
    • Progress-WinUIProgressRingPage.png
    • TabView-TabViewPage.png
    • Progress-WinUIProgressRing_CustomSources.png
    • Progress-WinUIProgressRing_Features.png
    • Transform-TransformToVisual_Translate2d.png
  • skia-wpf-screenshots: 9 changed over 1052

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Brushes-Ellipse.png
    • DragAndDrop-DragDrop_TestPage.png
    • Image-Image_Stretch_None_ScrollViewer.png
    • MUX-WinUIProgressRingPage.png
    • MUX-WinUIProgressRing_CustomSources.png
    • Progress-WindowsProgressRing_GH1220.png
    • Progress-WinUIProgressRingPage.png
    • Progress-WinUIProgressRing_CustomSources.png
    • Progress-WinUIProgressRing_Features.png
  • wasm: 17 changed over 1000

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • MUXControlsTestApp.PipsPagerPage
    • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ListView.ListView_IsSelected
    • UITests.Microsoft_UI_Xaml_Controls.ColorPickerTests.ColorPickerSample
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRingPage
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRing_Features
    • UITests.Shared.Microsoft_UI_Xaml_Controls.ColorPickerTests.WinUIColorPickerPage
    • UITests.Shared.Windows_UI_Xaml_Controls.ImageTests.Image_Stretch_Alignment_SizeOnControl
    • UITests.Windows_UI_Xaml_Controls.ProgressRing.WindowsProgressRing_GH1220
    • UITests.Windows_UI_Xaml.DragAndDrop.DragDrop_TestPage
    • UITests.Windows_UI_Xaml_Shapes.Offscreen_Shapes
    • Uno.UI.Samples.Samples.Shared.Content.UITests.ImageBrushInList
    • Uno.UI.Samples.UITests.Image.Image_Stretch_Alignment_Bigger
    • Uno.UI.Samples.UITests.Image.Image_Stretch_Alignment_Equal
    • Uno.UI.Samples.UITests.Image.Image_Stretch_Alignment_Smaller
    • Uno.UI.Samples.UITests.Image.Image_Stretch_Alignment_Taller
    • Uno.UI.Samples.UITests.Image.Image_Stretch_Alignment_Wider
    • Uno.UI.Samples.UITests.ImageBrushTestControl.Ellipse
  • wasm-automated-net5.0-Benchmarks: 0 changed over 1

  • wasm-automated-net5.0-Default: 8 changed over 877

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • BitmapImage_vs_SvgImageSource_SvgRemote_url_stream
    • DatePicker_Flyout_DatePicker_-_Flyout
    • ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
    • ScrollBar_Vertical_initial_indicators
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • TestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
    • When_PressOnContainerAndReleaseOnNested_Mouse_UITests_Windows_UI_Input_PointersTests_Nested_Sequence
    • When_TransformToVisual_ScrollViewer_UITests_Shared_Windows_UI_Xaml_UIElementTests_TransformToVisual_ScrollViewer
  • wasm-automated-net5.0-RuntimeTests: 0 changed over 1

nventive-devops avatar Aug 15 '22 18:08 nventive-devops

This change seems odd: https://dev.azure.com/uno-platform/Uno%20Platform/_build/results?buildId=51976&view=ms.vss-test-web.build-test-results-tab&runId=1910422&resultId=100409&paneView=debug Looks like it's adding one line at the bottom. Is it expected?

jeromelaban avatar Aug 16 '22 13:08 jeromelaban

Definitely not... It went from 8,8,8,8 to 8,8,8,9.

Xiaoy312 avatar Aug 16 '22 14:08 Xiaoy312