uno

uno copied to clipboard

GitHub Issue (If applicable): closes #3241

PR Type

What kind of change does this PR introduce?

• Feature

What is the current behavior?

No UI Test template for VSIX

What is the new behavior?

VSIX has a UI Test template

PR Checklist

Please check if your PR fulfills the following requirements:

• [ ] Docs have been added/updated which fit documentation template (for bug fixes / features)
• [ ] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
• [ ] Validated PR Screenshots Compare Test Run results.
• [ ] Contains NO breaking changes
• [ ] Associated with an issue (GitHub or internal) and uses the automatic close keywords.
• [ ] Commits must be following the Conventional Commits specification.

Other information

Internal Issue (If applicable):

Marking as a draft until I get more info on https://github.com/unoplatform/uno/issues/3241#issuecomment-934493428.

Nice work! Can you add a validation here: https://github.com/unoplatform/uno/blob/master/build/run-template-tests.ps1

GitHub

uno/run-template-tests.ps1 at master · unoplatform/uno

Build Mobile, Desktop and WebAssembly apps with C# and XAML. Today. Open source and professionally supported. - uno/run-template-tests.ps1 at master · unoplatform/uno

@jeromelaban Looks like this validation is for dotnet new, not VS templates, right? (I'll do it to validate that dotnet new isn't regressed as I actually forgot to confirm that - but it won't validate the VS template)

@jeromelaban Looks it's already tested actually?

https://github.com/unoplatform/uno/blob/981ab0d9f3dc8461112c91798eeaa9ba85c90e69/build/run-template-tests.ps1#L121-L124

Right! And it's not possible to test the vsix so you're good :)

/azp run

Azure Pipelines successfully started running 2 pipeline(s).

@Youssef1313 can you take a look at the conflicts for your PR please ;) ?

Thanks for the ping @agneszitte-nventive. I fixed the conflict, and this is now green :) 🎉

Thanks!!