unlock icon indicating copy to clipboard operation
unlock copied to clipboard

fix(smart-contracts): remove truffle

Open clemsos opened this issue 3 years ago • 1 comments

Description

This PR definitely removes Truffle. It consists mainly of replacing

  • the {from : address} by the connect(address) ethers pattern
  • the accounts by ethers's signers
  • replace use of tx.logs by const { events } = tx.wait() pattern
  • get rid of some web3 dependencies (such as OZ helpers)

NB: this is a MAJOR rewriting for the tests as w e are removing the legacy test suite so this PR will affect most test files

Issues

Fixes # Refs #

Checklist:

  • [ ] 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have updated the docs to reflect my changes if applicable
  • [ ] I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • [ ] I have performed a self-review of my own code
  • [ ] If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

clemsos avatar Jul 04 '22 10:07 clemsos

ok, this one is scary :D

julien51 avatar Jul 04 '22 14:07 julien51

Closing as @clemsos will use a different approach....

julien51 avatar Sep 12 '22 17:09 julien51