material-ui-currency-textfield icon indicating copy to clipboard operation
material-ui-currency-textfield copied to clipboard

Warning: componentWillReceiveProps has been renamed...

Open miliu99 opened this issue 5 years ago • 9 comments

I got this warning in browser:

Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

  • Move data fetching code or side effects to componentDidUpdate.
  • If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
  • Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run npx react-codemod rename-unsafe-lifecycles in your project source folder.

Please update the following components: CurrencyTextField

Any chance to update the component?

miliu99 avatar Feb 21 '20 16:02 miliu99

looks like this component is not supported anymore

SashaDesigN avatar May 02 '20 07:05 SashaDesigN

looks like this component is not supported anymore

Where did you see this? I was wondering if creating a pull request might help to make this going forward.

FlorianBouron avatar Jul 26 '20 09:07 FlorianBouron

I'm looking forward to fix for this warning as well. @FlorianBouron did you get a chance to create a pull request?

AlanC5 avatar Jan 13 '21 03:01 AlanC5

@FlorianBouron and @AlanC5 Please create a pull request, if you fixed the issue. We will merge.

sureshsevarthi avatar Jan 13 '21 14:01 sureshsevarthi

Are there any active maintainers who will merge if I submit a PR?

peacechen avatar Apr 20 '21 21:04 peacechen

Sure. We will accept PR's and merge.

On Tue, Apr 20, 2021 at 5:27 PM Peace @.***> wrote:

Are there any active maintainers who will merge if I submit a PR?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/unicef/material-ui-currency-textfield/issues/18#issuecomment-823610474, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKMYSVK2GD2GIRB4LGGXBRTTJXWSNANCNFSM4KZGQ3FQ .

sureshsevarthi avatar May 14 '21 02:05 sureshsevarthi

any prs?

chitgoks avatar Aug 05 '21 00:08 chitgoks

I see that there's a PR in the queue to fix this. Any chance a maintainer can review and approve it? Thanks!

JEAxero avatar Nov 03 '21 20:11 JEAxero

#37 fixes this issue. Can any maintainer review and approve it? Thanks in advance!

kenanerkorkmazmhp avatar Jan 03 '23 20:01 kenanerkorkmazmhp