translationCore icon indicating copy to clipboard operation
translationCore copied to clipboard

Percent complete is 99% for tW ru_rlob-2pe_book but it is all checked

Open birchamp opened this issue 3 years ago • 11 comments

This project https://git.door43.org/ru_gl/ru_rlob_2pe_tcore_checked_tW-checked_tN-aligned shows 99% complete even though it is entirely checked.

birchamp avatar Dec 07 '22 14:12 birchamp

@elsylambert at some point when you're testing tC can you test this issue?

birchamp avatar Dec 07 '22 14:12 birchamp

@birchamp Which tC version are you seeing this?

elsylambert avatar Dec 07 '22 14:12 elsylambert

Tested this project in translationCore 3.4.0 (146a9f1) . After importing the project, tW shows 99% completion, when no GL was selected. After choosing English-en-D43 catalog as GL, the tools card shows 100% completion. Screenshot 2022-12-07 at 9 48 36 AM

  • Download ru content, ru_gl, tW resources from content updater.
  • Select ru_gl as GL for tW card, the completion goes down to 99%.
Screenshot 2022-12-07 at 9 48 25 AM
  • Uncheck the "Key words" checkbox, the completion goes to 100%
Screenshot 2022-12-07 at 9 48 16 AM

elsylambert avatar Dec 07 '22 14:12 elsylambert

Note that all the checks in tW are completed. @PhotoNomad0

elsylambert avatar Dec 07 '22 14:12 elsylambert

@elsylambert How did you download this app? tCore is throwing an error for me that the url is not valid.

PhotoNomad0 avatar Dec 12 '22 15:12 PhotoNomad0

@PhotoNomad0 I did online import using the URL https://git.door43.org/ru_gl/ru_rlob_2pe_tcore_checked_tW-checked_tN-aligned last week.

elsylambert avatar Dec 12 '22 15:12 elsylambert

@elsylambert Oops, I'm using QA server!

PhotoNomad0 avatar Dec 12 '22 15:12 PhotoNomad0

@elsylambert I'm wondering if this is because they have 4 tw checks that are marked as no selection is needed?

PhotoNomad0 avatar Dec 12 '22 15:12 PhotoNomad0

@elsylambert Yes, making selections for those four checks eventually gets to 100%. Will have to check the algorithm to see if makes use of no checks needed.

PhotoNomad0 avatar Dec 12 '22 15:12 PhotoNomad0

@elsylambert @birchamp - It looks like there is a check that is failing:

Screenshot 2022-12-12 at 12 07 19 PM

It looks like the groupId should have been "righteous" instead of "righteousness"? Not sure why it is not displayed though.

Here is the check in https://git.door43.org/ru_gl/ru_twl/src/branch/master/twl_2PE.tsv on line186. The path is rc://*/tw/dict/bible/kt/righteousness, but in https://git.door43.org/ru_gl/ru_tw/src/branch/master/bible/kt there is no article righteousness.md, but there is one for righteous.md. It's looking like a bug that tW is not showing the checks when the article is missing. Continuing to look...

PhotoNomad0 avatar Dec 12 '22 17:12 PhotoNomad0

Notes:

  • see generateMenuData() in ./tc-ui-toolkit/src/GroupedMenu/utils.js - it probably should handle entries from index (groupsIndex) whose id is not in data (groupsData). Or maybe tCore should create categories for check items not defined.

PhotoNomad0 avatar Dec 13 '22 19:12 PhotoNomad0