Xuechen Liu

Results 19 comments of Xuechen Liu

I tried both options with program below. With torch 1.7.1 + torchaudio 0.7.2 (latest versions): ``` import torch import torch_dct as dct import scipy.fftpack x = torch.randn(200) X = dct.dct(x)...

@zh217 So in general, to recap I think apart from updating modules itself we need to upgrade our criteria on testing module. Do you have any ideas on it? For...

@adaxidedakaonang 是的,如果scale之后是符合的。所以我认为这个部分无伤大雅,可以loosen一些。@zh217 your thoughts?

Thanks a lot! Will have a check this week on some testing on numerical compatibility and version compatibility. And actually, as a contributor I am thinking about dropping support before...

Sorry @jbojar I have been so busy to get back to this. Finally can have a look. Yes I think your solution works ok, although I still recommend two things:...

@jonnor I think it is ready to merge. But obviously I do not have the permission. Maybe you can clone the repo from this PR and compile it locally in...

@zh217 Yes I am meeting same problem as well. But in short this is not happening for torch

@margaritageleta Thanks a lot for addressing. @zh217 Shall I fix it if you don't have time?

@GeJulia We have not since I have not heard @zh217 for a very long time. But you definitely can have a try with the code from PR #24, although from...

@EddyGiusepe I do not have too many things to add since the reply from @anautsch has already been fruitful enough. I will leave the main conversation between you two but...