Sharpmake icon indicating copy to clipboard operation
Sharpmake copied to clipboard

Published 20 hours ago • verified publisher icon ubisoft

Replace hardcoded doublequotes (Add readibility to string manipulation)

Open guiguibubu opened this issue 5 years ago • 2 comments

Job not finished. This MR is made only to discuss with maintainers to be sure that this improvement is useful

guiguibubu avatar May 16 '20 18:05 guiguibubu

I can see a value in that change, it improves readability, thanks!

belkiss avatar May 21 '20 10:05 belkiss

Just pushed an update. Replacement did in Sharpmake.Generator and Sharpmake "Core".

guiguibubu avatar May 24 '20 21:05 guiguibubu

We won't merge this. It doesn't improve readability and is not standard C#. Also, you forgot some $, probably breaking code.

jspelletier avatar May 12 '23 13:05 jspelletier