RIBs icon indicating copy to clipboard operation
RIBs copied to clipboard

Published 20 hours ago • verified publisher icon uber

Improve XRay implementation

Open lucasnlm opened this issue 2 years ago • 5 comments

Description: This PR adds setup(), XRayConfig to RIBs XRay to allow setup it without rely on the existing toggle() function.

Problem it fixes The current toggle() function may be problematic because it changes a static boolean. Example: depending on where XRay is enabled or if it's as debug in a RIB used twice, it will enabled and disable immediately.

XRayConfig adds the ability to enable XRay without change the Views alpha. The alpha change may be problematic when we have many RIBs attached due to the overlapping.

lucasnlm avatar Sep 06 '23 21:09 lucasnlm

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 06 '23 21:09 CLAassistant

@lucasnlm please build a version of RIBs with your change and make sure it works as expected using our apps, if so we can go ahead with landing

psteiger avatar Sep 22 '23 00:09 psteiger

@psteiger How can I do that?

lucasnlm avatar Sep 23 '23 15:09 lucasnlm

@lucasnlm I tagged on in internal comms with smoke test instructions

psteiger avatar Oct 06 '23 22:10 psteiger

@lucasnlm I tagged on in internal comms with smoke test instructions

I hope to test it this week. Thanks for the reminder.

lucasnlm avatar Oct 12 '23 02:10 lucasnlm