opentracing-python-instrumentation icon indicating copy to clipboard operation
opentracing-python-instrumentation copied to clipboard

Published 20 hours ago • verified publisher icon uber-common

@traced_function now works with AsyncIO's coroutines.

Open nicholasamorim opened this issue 6 years ago • 3 comments

When using Tornado 5 it's common to start migrating to async/await syntaxes.

However, @traced_function only understands Tornado's Futures but not necessarily AsyncIO coroutines.

This PR adds supports to it without breaking compatibility with older versions of Python.

nicholasamorim avatar May 23 '19 11:05 nicholasamorim

Coverage Status

Coverage increased (+2.3%) to 79.286% when pulling 6bbcf2c8df4deae0d5844d360605f0a33ecfc073 on nicholasamorim:traced_function_asyncio into 4d560d529275586cf8ffbb28278357083c999a95 on uber-common:master.

coveralls avatar May 23 '19 11:05 coveralls

Thanks for you suggestions @Jamim.

I will look into this PR that was suggested by @condorcet https://github.com/opentracing/opentracing-python/pull/118 and see how I can improve this. Accepting any pointers, though.

nicholasamorim avatar Jun 17 '19 17:06 nicholasamorim

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Nicholas Amorim seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Oct 04 '20 10:10 CLAassistant