u-dales
u-dales copied to clipboard
Further namoptions cleanup
This issue is about cleaning up the list of parameters that can be set in the namoptions input file. There are a few points up for discussion (we might also want to break them into separate issues):
&RUN
- [ ] lles = .true. Discuss whether to remove non-LES functionality
- [ ] randu = 0. Default changed from 0.5 in DALES. Should we change back?
- [ ] randthl = 0. Default changed from 0.1 in DALES. Should we change back?
- [ ] randqt = 0. Default changed from 1e-5 in DALES. Should we change back?
- [ ] courant = -1 Code sets it to 1.5 or 1.1 (if Kappa or upwind scheme is used). These are different values than in DALES!
- [ ] diffnr = 0.25 Diffusion number? Used to determine adaptive time step. Can we get rid of it?
- [ ] lreadmean = .false. Potentially deprecated. Should we remove it?
- [ ] lper2inout = .false. Potentially deprecated. Should we remove it?
- [ ] lwalldist = .false. Switch to calculate wall effects for the subgrid models (Smagorinsky or one equation). Potentially deprecated. Should we remove it?
- [ ] lstratstart = .false. Description missing.
&BC
- [ ] wtsurf = -1. What to do with subroutine bottom?
- [ ] wqsurf = -1.
- [ ] thls = -1.
- [ ] z0 = -1.
- [ ] z0h = -1.
- [ ] !wsvsurfdum = Should be reviewed when checking scalars implementation
- [ ] !wsvtopdum =
&WALLS
- [x] iwallmom = 2 Should we set default to 3? (neutral wall function) Will need to test this first! Edit: We decided to remove option 3 from the user documentation as the code chooses this automatically for neutral simulations
&PHYSICS
- [ ] igrw_damp = 2 Gravity wave dumping. We use = 0 (no damping).
&DYNAMICS
- [ ] iadv_tke = -1 Only applicable if loneeqn = True. Consider removing this option?
- [ ] iadv_qt = -1 Should we extend and test use of option 7 (Kappa scheme)?
- [ ] iadv_sv = -1 Consider removing option 1 (upwind scheme)?
- [ ] ipoiss = 1 Should be set to ipoiss = 0 when bug in EB is fixed (Issue #61).
&NAMSUBGRID
- [ ] loneeqn = .false. Should we remove this?
&INLET
- [ ] linletRA = .false. These parameters are associated with the turbulent inlet generation. They are untested with the current version of the code. Remove or update?
- [ ] lfixinlet = .false.
- [ ] lfixutauin = .false.
&SCALARS
- [ ] lreadscal = .false. Deprecated, should we remove?
- [ ] lscasrc = .false. Description missing
- [ ] lscasrcl = .false. Description missing
general:
- [ ] ensure consistent spacing before and after
=when namoptions are changed byda_inp.shandda_prep.sh.
Additional points:
- Consistent spacing after
=and this applied in da_inp and da_prep where we edit values in namoptions. -
BCbotTdefault should be 1 to matchiwalltemp.
BCbotTdefault should be 1 to matchiwalltemp.
Shall we do a pull request and fix this right away?
Okay yeah I will do this now
@bss116 See #74