u-bmc icon indicating copy to clipboard operation
u-bmc copied to clipboard

pkg/aspeed/lpc_mem.go arguments end up everywhere

Open osresearch opened this issue 6 years ago • 1 comments

For some reason the --lpc_cache and --print_lpc_stats command line arguments from pkg/aspeed/lpc_mem.go are ending up in every command. For example:

~# pwd --help
Usage of pwd [-LP]:
  -L	don't follow any symlinks (default true)
  -P	follow all symlinks (avoid all symlinks)
  -lpc_cache
    	Do not write values that match cached view of LPC2AHB F0-9 registers
  -print_lpc_stats
    	At the end of the run, print LPC statistics

or

~# date --help
Usage of date [-u] [-d FILE] [+format] | date [-u] [-d FILE] [MMDDhhmm[CC]YY[.ss]]:
  -lpc_cache
    	Do not write values that match cached view of LPC2AHB F0-9 registers
  -print_lpc_stats
    	At the end of the run, print LPC statistics
  -r string
    	Display the last midification time of FILE
  -u	Coordinated Universal Time (UTC)

osresearch avatar Aug 15 '19 10:08 osresearch

It's an artifact from the way I used to do flags. Those are legacy anyway, so we should just remove them.

bluecmd avatar Aug 15 '19 14:08 bluecmd