Tomasz Zdybał
Tomasz Zdybał
A totally agree, that this is a great & 'keep-it-simple' approach :+1:
The `maxBytes` is definitely confusing. I agree that sequencer should make small enough batches, but on the other hand, `maxBytes` was one of the ways to signal sequencer that expected...
> 1. Why do we need to return maxBytes in InitChain and ExecTxs? Max bytes should be defined in genesis file, and possibly can be changed during execution. So the...
Created https://github.com/rollkit/go-execution/issues/54 as follup-up issue.
There is definitely a potential to reuse buffers (I feel we should be able to use only 3 buffers for every `computeRoot` recursive call stack). Currently the code is really...
One low-hanging-fruit is to stop allocating and copying data for leaf hashes - we can just return pre-computed values without copying.
The main blocker for implementation is refactoring peer filtering from `AddPeer` to `InitPeer`. ~I'm currently working on this, but some unit tests are still failing - debugging in progress.~ Once...
CC: @robert-zaremba
Some thoughts: * hasher should be "external" (take header as arg, not be a member function) * hasher provided as callback
I created a discussion here: https://github.com/celestiaorg/celestia-core/discussions/2221 It's based on my thoughts and discussion during sprint call last week.