laravel-scout-typesense-driver icon indicating copy to clipboard operation
laravel-scout-typesense-driver copied to clipboard

Published 20 hours ago • verified publisher icon typesense

Bugfix/Reduce unnecessary API calls

Open arayiksmbatyan opened this issue 2 years ago • 2 comments

Change Summary

PR Checklist

arayiksmbatyan avatar Feb 06 '23 11:02 arayiksmbatyan

I think it's better to revert that change, as in https://github.com/typesense/laravel-scout-typesense-driver/pull/50 or https://github.com/typesense/laravel-scout-typesense-driver/pull/47 rather than merging this one.

michgeek avatar Feb 15 '23 14:02 michgeek

This could work, but instead of the check for running in console, wouldn't it be better to just do the dirty check for each of the models in the collection? Then filter it down based on that?

manavo avatar Feb 27 '23 20:02 manavo