django-stubs
django-stubs copied to clipboard
typeddjango
Avoid returning None from get_field_related_model_cls
https://github.com/typeddjango/django-stubs/pull/1495 updated get_field_related_model_cls to raise UnregisteredModelError rather than returning None for failure paths. However, None can still be returned if the initial retrieval of related_model_cls returns None.
This patch adds a check to see if the initial retrieval has got a None and then raises the appropriate error rather than letting None be returned.
Related issues
Closes https://github.com/typeddjango/django-stubs/issues/1953
Do you think that adding a test case is a good idea here?
yeah I think it would be great to add a test case to tests/typecheck/fields/test_related.yml with a minimal reproducible example :pray:
Updated to shift location of check.
I'm open to suggestions re tests. The scenario I'm encountering this in is some proprietary code that I'm yet to reduce to something that nicely fits into a test here.
I've been traveling, and will make some time to get my branch updated over the next couple of days.
I've reverted the changes back to the first iteration of PR. I'm afraid I haven't had any luck in reducing the faulting code to a test case.
FWIW, the scenario I'm seeing this hit in is using django taggit. I'm not certain what's going on under the hood that's resulting in the unhappiness however.