typedb-driver icon indicating copy to clipboard operation
typedb-driver copied to clipboard

Add driver fields to the connection open request

Open dmitrii-ubskii opened this issue 1 year ago • 2 comments

Usage and product changes

Added and populated driver name and version fields to the Connection.Open request payload.

Note: despite proto3 being able to handle added fields, due to a library packaging issue, older versions of TypeDB cannot handle new fields. This means that this change breaks compatibility with TypeDB server 2.25.x and earlier.

dmitrii-ubskii avatar Dec 14 '23 11:12 dmitrii-ubskii

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

  • [ ] This change is trivial and does not require a code or architecture review.

Code

  • [ ] Packages, classes, and methods have a single domain of responsibility.
  • [ ] Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • [ ] The code is canonical and the minimum required to achieve the goal.
  • [ ] Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • [ ] Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • [ ] The code is algorithmically efficient and scalable for the whole application.

Architecture

  • [ ] Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • [ ] Any required build and release automations are updated and/or implemented.
  • [ ] Any new components follows a consistent style with respect to the pre-existing codebase.
  • [ ] The architecture intuitively reflects the application domain, and is easy to understand.
  • [ ] The architecture has a well-defined hierarchy of encapsulated components.
  • [ ] The architecture is extensible and scalable.

typedb-bot avatar Dec 14 '23 11:12 typedb-bot

We preserve this PR until 3.0.0 as it breaks backward compatibility, and we don't want to break it until 3.0.0.

farost avatar Apr 08 '24 09:04 farost