tween.js icon indicating copy to clipboard operation
tween.js copied to clipboard

Published 20 hours ago • verified publisher icon tweenjs

tweening to arrays of values has bug

Open tvytlx opened this issue 4 years ago • 2 comments

_valuesEnd[property]'s length will grow endless, because it's a reference to this.valuesEnd

https://github.com/tweenjs/tween.js/blob/8db070d25a82c19772352bbcbc33a326e6882b4e/src/Tween.ts#L138-L150

checking this demo, just click the start button twice or more: https://jsbin.com/hulidowipa/edit?html,js,output

tvytlx avatar Aug 12 '21 10:08 tvytlx

@trusktr hi, could you please check my pr? 🙏

tvytlx avatar Aug 13 '21 13:08 tvytlx

Hello, sorry for the late reply. Thanks for looking at this!

The build in the PR has an error with Prettier. Would you mind adding a small unit test for this?

trusktr avatar Dec 02 '21 02:12 trusktr

fixed in #621

trusktr avatar Apr 23 '23 05:04 trusktr