bootstrap

bootstrap copied to clipboard

Description

Adds a guard rail/sanity check to the keyboard handler, to bail out if there's no actual toggle button

Motivation & Context

While good practice in general (as it does not assume there is a toggle button), this also prevents the type error in our documentation where we have examples of dropdown menus that are "static" and already opened.

Type of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Refactoring (non-breaking change)
• [ ] Breaking change (fix or feature that would change existing functionality)

Checklist

• [x] I have read the contributing guidelines
• [x] My code follows the code style of the project (using npm run lint)
• [ ] My change introduces changes to the documentation
• [ ] I have updated the documentation accordingly
• [ ] I have added tests to cover my changes
• [ ] All new and existing tests passed

Live previews

https://deploy-preview-37755--twbs-bootstrap.netlify.app/docs/5.3/components/dropdowns/#active

Related issues

Closes https://github.com/twbs/bootstrap/issues/37428

As much as I want to protect us of future misleading issues related to docs examples, I would never prefer to add this dummy "silencer" as it will affect the real implementations' strictness and feedback. And for sure, a dropdown without a toggler, has wrong markup 😞

Maybe is a better, just add a note on dropdown examples

x-ref https://github.com/twbs/bootstrap/pull/34349

any decision/thoughts on this?

@GeoSot @julien-deramond so what do we want to do here? I think the options are to:

• tweak the documentation to somehow silence/special case the open dropdowns used as examples (and maybe be more explicit in the documentation about our dropdown menu actually needing to be in a menu), or
• add this guard rail here (and maybe still do the documentation tweak above)