XcodeProj
XcodeProj copied to clipboard
Consider UUIDs when sorting by name
Resolves https://github.com/tuist/XcodeProj/issues/683
Short description π
Ensure UUIDs are considered during sort by filename to ensure information is not lost when filenames are equal.
Solution π¦
Consider both the PBXBuildFile UUID and PBXFileElement UUID.
Implementation π©βπ»π¨βπ»
Detail in a checklist the steps that you took to implement the PR.
- [X] Consider all UUIDs when filenames are equal
- [X] Update documentation
- [X] Rename sort methods differently so they can be distinguished at the call site
Codecov Report
Merging #685 (bf90957) into main (65ca255) will increase coverage by
0.00%. The diff coverage is100.00%.
:exclamation: Current head bf90957 differs from pull request most recent head 54df1b5. Consider uploading reports for the commit 54df1b5 to get more accurate results
@@ Coverage Diff @@
## main #685 +/- ##
=======================================
Coverage 84.84% 84.84%
=======================================
Files 157 157
Lines 9044 9049 +5
=======================================
+ Hits 7673 7678 +5
Misses 1371 1371
| Impacted Files | Coverage Ξ | |
|---|---|---|
| .../XcodeProj/Objects/Project/PBXOutputSettings.swift | 100.00% <100.00%> (ΓΈ) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact),ΓΈ = not affected,? = missing dataPowered by Codecov. Last update 65ca255...54df1b5. Read the comment docs.
@kwridan I've added tests for that, but there are now some other failing tests due to adding files to iOS/Project.xcodeproj. They seem "magic numbery". Can you advise?


I addressed the comments on this PR in a separate one. Thanks a lot for this contribution @timothycosta ππΌ
@all-contributors please add @timothycosta for code