lnav icon indicating copy to clipboard operation
lnav copied to clipboard

[Feature request] Show the current filters beside Not Shown

Open cw1nte opened this issue 6 years ago • 7 comments

This needs fitting to space and handle overlong lists somehow (...?), ideally sort and show hits per filter.
Do we know and count each where multiple filters match in hidden line? (e.g. below 90% of sandbox logs are by the kernel on my system so #kernel should > #sandbox unless kernel is matched first, in line word order, and pattern matching ceases which I imply in my sample.)

Maybe hidden is more compact?

L12,345 95% 1234 hits 13,567 hidden: Sandbox(2,100) kernel(1,478) success(1,234)... ? Help

cw1nte avatar Nov 28 '18 10:11 cw1nte

maybe the "Not shown/hidden" should come before the pattern match info as that groups the lines, content and % nav info; then the hits info (see my other show search string for hits suggestion).

L12,345 95% 13,567 hides Sandbox(2,100) kernel(1,478) success(1,234)... 234 hits/mux-device ?Help

cw1nte avatar Nov 28 '18 11:11 cw1nte

I have 0.8.4 from brew, looks like filters panel is added to 0.8.5 I do not even know the release-to/update brew sources mechanism!

cw1nte avatar Nov 28 '18 15:11 cw1nte

I think the --HEAD flag is what you're looking for:

brew upgrade --HEAD lnav

tstack avatar Nov 28 '18 15:11 tstack

The new candidate vastly improves filter functions. I'd still love to see the count by each filter when the tab opens or on that new, big, empty filters line. Personally I'd compact that into a zone within the single info line, then tab could pop up more rows or even filter edit and details as another view mode (like the sql data return) that we can just toggle to and from (using f?) if that does not break the existing patterns.

cw1nte avatar Nov 29 '18 11:11 cw1nte

Now that HAED is doing counts I think this could close, my only suggest is maybe sort filters list in TAB window by hits descending?

cw1nte avatar Feb 19 '19 09:02 cw1nte

my only suggest is maybe sort filters list in TAB window by hits descending?

That makes things a bit complicated since the order would be switching around as new lines arrived. I added the lnav_view_stats SQL table to handle this use case.

tstack avatar Feb 20 '19 02:02 tstack

Ohh, I assumed you were just using a SQL query to show the lines in the TAB view and could simply add an ORDER BY clause at the end!

cw1nte avatar Feb 20 '19 09:02 cw1nte