tree-sitter-ocaml icon indicating copy to clipboard operation
tree-sitter-ocaml copied to clipboard

Fix some issues with building the project on macos

Open ddickstein opened this issue 1 year ago • 1 comments

Fixes a couple issues I ran into when building the project on macos:

  1. Without the \ in the SONAME_MINOR line, make failed with:
/Library/Developer/CommandLineTools/usr/bin/make -C grammars/ocaml all
../../common/common.mak:39: *** unterminated call to function `shell': missing `)'.  Stop.
make: *** [all] Error 2

with the \, the replacement still seems to work (at least on macos). 2. Depend directly on grammar.js instead of grammar.json, which is itself generated from grammar.js. This ensures that modifications to grammar.js get reflected in the parser without you needing to remember to separately call make generate.

ddickstein avatar Sep 26 '24 19:09 ddickstein