sidetree.js icon indicating copy to clipboard operation
sidetree.js copied to clipboard

Use an hd path unique to sidetree to generate keys

Open gjgd opened this issue 5 years ago • 4 comments

Currently the ethereum path is being used

https://github.com/transmute-industries/sidetree.js/blob/da3e1fb2491635cdb3b20973ad2bf4c54766bf79/packages/core/src/util/Jwk.ts#L42

gjgd avatar Aug 07 '20 10:08 gjgd

This might (probably) be based on me misunderstanding, but does the same thing need to be done here https://github.com/transmute-industries/sidetree.js/blob/9dc99384915c1cde84b850792dc6893940ebc738/packages/crypto/src/constants.ts#L19 and here? https://github.com/transmute-industries/sidetree.js/blob/9dc99384915c1cde84b850792dc6893940ebc738/packages/wallet/src/constants/index.ts#L24

And would the wallet package in this repo be considered enough of an 'implementation' so that Sidetree could be listed on SLIP-0044?

NickDarvey avatar Oct 04 '20 03:10 NickDarvey

It looks like this issue is still relevant, so instead of closing it, i'll try to update it with more context and tasks. In this case the wallet used for sidetree for update operations is using the same type as Ethereum.

https://github.com/transmute-industries/sidetree.js/blob/main/packages/dashboard/core/DashboardWallet.test.ts

Since we're creating a wallet for Element-specific purposes, we should be defining the wallet as such. This means that we need to create a specific number to identify the wallet-type, and then we need to send a pull request to https://github.com/satoshilabs/slips/blob/master/slip-0044.md to have it recognized.

BenjaminMoe avatar Dec 23 '21 17:12 BenjaminMoe

I think for the time being, for Element we might continue to use an Ethereum based HD path unless there is a specific need to do otherwise. Welcome to more input on this.

BenjaminMoe avatar Jan 14 '22 16:01 BenjaminMoe

we seem to be defaulting towards assuming /0... see also https://api.did.actor/docs

OR13 avatar Jan 19 '22 19:01 OR13