traefik-helm-chart icon indicating copy to clipboard operation
traefik-helm-chart copied to clipboard

Published 20 hours ago • verified publisher icon traefik

Only create one Service based on version check

Open valerauko opened this issue 4 years ago • 3 comments
trafficstars

This is the continuation of #311. I cherry-picked @0xThiebaut's commits and added the tests as requested in #311.

Since the rancher-maintained helm-unittest does not support mocking Capabilities, I switched to an apparently better-maintained other fork.

valerauko avatar May 15 '21 11:05 valerauko

Ping @SantoDE since you asked for tests in the original PR

valerauko avatar May 15 '21 11:05 valerauko

On the other hand, using this still requires a feature gate enabled in the apiserver...

https://kubernetes.io/docs/concepts/services-networking/service/#load-balancers-with-mixed-protocol-types

valerauko avatar May 15 '21 13:05 valerauko

Saw that this PR actually has the testing. Could we update the version from 1.20 to 1.24 for Kubernetes? Mixed protocol is now beta and is enabled by default going forward.

Elegant996 avatar Aug 24 '22 14:08 Elegant996

Superseded by #656

mloiseleur avatar Oct 11 '22 15:10 mloiseleur