GTAO_Booster_PoC icon indicating copy to clipboard operation
GTAO_Booster_PoC copied to clipboard

Published 20 hours ago • verified publisher icon tostercx

[boost.c] is ill-formed (no diagnosis required): The Standard reserves function names beginning with ‘str’ or ‘mem’ for possible future use.

Open ViralTaco opened this issue 4 years ago • 3 comments

Hi,

Issue:

https://github.com/tostercx/GTAO_Booster_PoC/blob/fd8eaa8661500995442a0fe079b02e740845afe9/boost.c#L33 The name strlen_cached is reserved by the standard.

cf: ISO/IEC 9899:201x

  • §7.1.3 Reserved identifiers p182
  • §7.31.12 General utilities <stdlib.h> p456
  • §7.31.13 String handling <string.h> p456

NB: Also reserved are… Well, there's a fat list, really. Here is the most useful link you'll ever get for fast reference to the C and C++ Standards and libraries: cppreference.com C Reserved Identifiers

Current Behavior:

Undefined. Any, or none.

Expected Behavior:

The behavior of an identical function given a valid, unreserved, name.

Proposed Solution:

Change the name of the function. eg: cached_strlen

ViralTaco avatar May 23 '21 00:05 ViralTaco

If you read it again, it's called strlen_cacher and not strlen_cached

mempler avatar Aug 11 '21 05:08 mempler

Yeah, apparently anything starting with str followed by a lowercase letter is reserved for future use, so this would still apply. Had no idea,

tostercx avatar Aug 11 '21 08:08 tostercx

Lets just simply call it Superduperwhoopsboopsnonstdcompliant_strlen_cacher 😄 Jokes aside, truly a good first issue.

mempler avatar Aug 12 '21 01:08 mempler