torchmd-net icon indicating copy to clipboard operation
torchmd-net copied to clipboard

Added versioneer and updated setuptools building

Open stefdoerr opened this issue 1 year ago • 5 comments

stefdoerr avatar Feb 23 '24 09:02 stefdoerr

Done I think. Tests pass, so we should be fine

stefdoerr avatar Feb 23 '24 09:02 stefdoerr

Looking at the versioneer README it seems like one of the steps requires running "versioneer install --no-vendor". I understand this is what generated the big _version.py file and it is not required to run it again? (unless to update versioneer I guess). Also, does this add versioneer as a dependency?

RaulPPelaez avatar Feb 23 '24 10:02 RaulPPelaez

Yes, although I've stopped using that command because it touches too much stuff which I don't want it to. So I usually just copy the _version.py from a previous project, modifying the package name in it and do the rest manually. I don't like sneaky executables modifying my codebase

stefdoerr avatar Feb 23 '24 10:02 stefdoerr

It also appears that versioneer is just a build time dependency, which is nice.

RaulPPelaez avatar Feb 23 '24 10:02 RaulPPelaez

Yes, since we ship that big _version.py file you don't need to add it as a runtime dep

stefdoerr avatar Feb 23 '24 10:02 stefdoerr