flowchart-fun icon indicating copy to clipboard operation
flowchart-fun copied to clipboard

Hyperlinks not displaying beyond "https:" and increase border auto-resize max limits

Open alarsama opened this issue 4 years ago • 5 comments

I love how simple this is and how this works. I would like to request the following fixes:

  • URLs do not show as hyperlinks: Screen Shot 2021-03-08 at 5 03 28 PM

  • Text height goes beyond border height - expand auto-resize max limit?: Screen Shot 2021-03-08 at 5 04 40 PM

  • Text width goes beyond border width expand auto-resize max limit?: Screen Shot 2021-03-08 at 5 06 13 PM

PS. Thank you for this! It's so cool.

alarsama avatar Mar 09 '21 01:03 alarsama

Good find about the url's. I tried to add box auto-resizing over the weekend but obviously it still needs some work.

Thanks for opening this issue. I'll try to get a fix in tomorrow!

rob-gordon avatar Mar 09 '21 02:03 rob-gordon

Because we allow inline javascript style comments // like this, you'll need to escape the // in url's, like http:\/\/myurl.com

The box sizing should grow horizontally and vertically now 👍

rob-gordon avatar Mar 09 '21 14:03 rob-gordon

Wow! This is great. Thanks for the prompt response and fixes!

  • I can confirm with some brief tests that box resizing works great.
  • URLS now show up after escaping the "//" characters. With URLs now showing up properly, would you be open to allowing URLs to be clickable hyperlinks?

alarsama avatar Mar 09 '21 17:03 alarsama

@alarsama I wanted to mention that there has been a small change in how lines are parsed such that escaping url's will no longer work. Now, you'll need to uri-encode them.

I made this switch so that I could support not only url's but other things like new lines, tabs, etc.

The longer term plan, which will inevitably fix your comment-

With URLs now showing up properly, would you be open to allowing URLs to be clickable hyperlinks?

is to then run the uri-decoded text through a markdown parser, which hopefully means we can have support for links, rich text like headings, bold, italics; and maybe even images!

I'm going to continue to leave this issue open until we can support that stuff, but I just wanted to flag that your hyper links that may have looked like http:\/\/hello-world.com may need to be switched to the uri encoded version (i.e., http%3A%2F%2Fhello-world.com) Sorry for any inconvenience!

rob-gordon avatar Apr 13 '21 15:04 rob-gordon

Hello Rob,

Wow! Thanks for the follow-up! Very cool.

Best Regards, Alan

alarsama avatar Apr 16 '21 02:04 alarsama

Resizing and hyperlinks are supported ✅

rob-gordon avatar May 30 '23 17:05 rob-gordon