git_stats
git_stats copied to clipboard
tomgi
Remove Author.email field and merge authors by name
For example John Smith <[email protected]> and John Smith <[email protected]> are considered as a single author John Smith regardless of the different email addresses.
As the URL for author details is constructed from Autor.dirname (as opposed to Author.email - see dc4d2a0) the original version does not work properly.
This change is just a workaround and is not intended for a direct merge, I created it just to trigger a discussion.
However, for me personally it feels as a suitable quickfix until the whole issue is properly addressed.
Thanks for pointing the problem with author details URL.
I think better solution than removing email field from author would be to:
- save collection of author's emails in author class
- add option in API and CLI to merge authors with specified emails (so they will be considered as a single author)
Hello Tomasz, Yes, the approach you described is definitely better. Ideally there could be also an option to merge all authors (to avoid listing the e-mails and still get the behavior I achieved with my hack). BTW. thank you very much for a great piece of software! The presentation looks so much nicer that with the original gitstats. Cheers, Filodej.
Ping for this - CLI-wise, I agree that a toggle to allow the operator to turn off the email behavior is a good idea. Where did this idea stall?
