esm-potrace-wasm icon indicating copy to clipboard operation
esm-potrace-wasm copied to clipboard

Published 20 hours ago • verified publisher icon tomayac

Try to improve the build

Open tomayac opened this issue 4 years ago • 2 comments
trafficstars

Fixes #2 (eventually… 🙄)

tomayac avatar Nov 19 '21 15:11 tomayac

Uncertain what the issue is, but this is what I see when running this branch locally:

Uncaught (in promise) TypeError: svg.replaceAll is not a function

image

The return value is a number, likely the memory reference of the string generated in WASM. I'd look further but I see there's a lot of new code in main so it's not so simple to determine what isn't really working for you. If you rebaseline this branch and say more about the problem I'm happy to lend a hand.

FWIW, the changes in this PR seem correct to me. I'd expect it to work.

also a little confused why when building from master and running the demo, I don't see any WASM in the network panel. then I saw it was inlined in the JS as a data url 👀

connorjclark avatar Apr 01 '22 23:04 connorjclark

@connorjclark I have opened a new PR: https://github.com/tomayac/esm-potrace-wasm/pull/7. Leaving this one open for comparison.

tomayac avatar Apr 04 '22 12:04 tomayac