tracing icon indicating copy to clipboard operation
tracing copied to clipboard

Expose Writer::new as public

Open goodspark opened this issue 2 years ago • 6 comments

Solves #2512

I'm writing a custom formatting layer and want to use UtcTime and format_time to format the time into a string.

goodspark avatar Mar 21 '23 18:03 goodspark

Any update on this? I have this implemented in my own fork, but for some reason other crates that use a different version no longer work with the global subscriber, so getting this officially implemented would be great! I can make a new merge request with comments, but I'm not sure of all the considerations that need to be taken into account.

kaifastromai avatar Apr 05 '23 19:04 kaifastromai

Any update on this?

kaifastromai avatar Jun 14 '23 14:06 kaifastromai

Is there any way to yet again request eyes on this/the new PR (#2680)/the issue (#2512)? This minor change not being handled has blocked my ability to update :/ I do understand no one is under any obligation to spend their time working on this, but the new PR does resolve the comments here and seems to have been completely ignored. Hopefully putting in an extra ping is a valid reminder.

kayabaNerve avatar Oct 10 '23 21:10 kayabaNerve

Is there any way to yet again request eyes on this/the new PR (#2680)/the issue (#2512)? This minor change not being handled has blocked my ability to update :/ I do understand no one is under any obligation to spend their time working on this, but the new PR does resolve the comments here and seems to have been completely ignored. Hopefully putting in an extra ping is a valid reminder.

Hi, I've reviewed the new PR, #2680. Hopefully we can get that merged soon.

Sorry I didn't address this sooner --- I'm more or less the only maintainer of all the tracing crates in this repo, and ongoing tracing maintenance is not one of my primary responsibilities for my employer, so I don't always have time to keep up with activity on PRs like this one, and sometimes they slip through the cracks. I don't mind the ping, and I'm sorry that this not being merged sooner has inconvenienced you!

hawkw avatar Oct 10 '23 21:10 hawkw

Don't worry at all! I totally get it. FOSS can be a busy mess. I appreciate all the work you do, just wanted to do what I can to help move things forward :)

Thanks for handling this!

kayabaNerve avatar Oct 11 '23 01:10 kayabaNerve

This can be closed as #2680 has been merged.

mladedav avatar May 26 '24 23:05 mladedav