tracing icon indicating copy to clipboard operation
tracing copied to clipboard

Published 20 hours ago • verified publisher icon tokio-rs

subscriber: make `reload` an optional feature

Open Folyd opened this issue 4 years ago • 5 comments

Motivation

reload is a useful feature for some applications such as web-app but is unnecessary for the others such as CLI-app. I think this feature should be optional.

Solution

Just add a new feature flag called reload and make it optional.

Folyd avatar Mar 09 '21 12:03 Folyd

Orz, this PR didn't catch the v0.3 release. 😅 Can we merge this?

Folyd avatar Oct 25 '21 03:10 Folyd

Sorry! We missed this change for 0.3. The chrono vulnerability was somewhat urgent and we missed a few breaking changes that we wanted to get it. Somewhat naively, I worry that maintaining this on master while not backporting this to v0.1.x will be somewhat annoying. If it's okay with you, I'd like to keep this PR open, but mark it with a tracing-subscriber-0.4 tag so that we don't forget to merge it ahead of that release.

davidbarsky avatar Nov 24 '21 17:11 davidbarsky

Thanks, @davidbarsky. 😸

Folyd avatar Nov 25 '21 01:11 Folyd

Added the tracing-subscriber 0.4 milestone to this issue, I think this is still a valid candidate for getting merged. Let's keep it open for now.

cc @davidbarsky

bryangarza avatar May 09 '22 19:05 bryangarza

Yeah, I'd like to consider a breaking release for a couple other changes, so when we do one, we should make sure this actually gets in too.

hawkw avatar May 09 '22 20:05 hawkw