tracing-opentelemetry icon indicating copy to clipboard operation
tracing-opentelemetry copied to clipboard

Published 20 hours ago • verified publisher icon tokio-rs

enhancement: add gauge metric behind feature

Open academiaresf opened this issue 1 year ago • 2 comments

Motivation

The opentelemetry crate actually supports Gauge metric behind otel_unstable feature.

Solution

Extend the current implementation with the treatment for the new Gauge metric.

The tests are passing but i don't know if there are necessary other type of tests (at this point, the property start_time inside the DataPoints of the Gauge type are None in all the test, for example. L664 of tests/metrics_publishing.rs file).

academiaresf avatar Mar 17 '24 21:03 academiaresf

Any chance it will be merged?

biryukovmaxim avatar Apr 29 '24 18:04 biryukovmaxim

Hello guys, I made an another pr based on the branch there are some tests fixes, guard them by feature, add --all-features flag to cicd. I hope I didn't offend you, @academiaresf . You did a nice job!

biryukovmaxim avatar Apr 30 '24 08:04 biryukovmaxim

since https://github.com/tokio-rs/tracing-opentelemetry/pull/129 is merged - this one can be closed

biryukovmaxim avatar May 24 '24 09:05 biryukovmaxim

@academiaresf thanks for jumpstarting this!

djc avatar May 24 '24 09:05 djc

@biryukovmaxim thanks for completing it, i didn't have time to continue with this

academiaresf avatar Mar 18 '25 22:03 academiaresf