feat(core): replace page filter, journal's date-picker with new one

Open CatsJuice opened this issue 2 years ago • 3 comments

Jan 23 '24 09:01 CatsJuice

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Jan 23 '24 09:01 graphite-app[bot]

Current dependencies on/for this PR:

#5681
#5675 👈
#5654
canary

This stack of pull requests is managed by Graphite.

Jan 23 '24 09:01 CatsJuice

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (e664494) 64.55% compared to head (3fe9d83) 64.51%.

Files	Patch %	Lines
...onent/src/ui/date-picker/calendar/month-picker.tsx	0.00%	2 Missing :warning:
...ponent/src/ui/date-picker/calendar/year-picker.tsx	0.00%	2 Missing :warning:
...re/src/components/page-list/filter/date-select.tsx	71.42%	2 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##           canary    #5675      +/-   ##
==========================================
- Coverage   64.55%   64.51%   -0.05%     
==========================================
  Files         358      360       +2     
  Lines       19944    19956      +12     
  Branches     1701     1701              
==========================================
- Hits        12875    12874       -1     
- Misses       6848     6863      +15     
+ Partials      221      219       -2

Flag	Coverage Δ
server-test	`71.35% <ø> (ø)`
unittest	`45.37% <53.84%> (-0.13%)`	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Jan 23 '24 09:01 codecov[bot]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3fe9d834de40fa4890ac778387d3fc3d745a3c11. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

Feb 19 '24 07:02 nx-cloud[bot]

Merge activity

Feb 20, 8:52 AM EST: Brooooooklyn added this pull request to the Graphite merge queue.
Feb 20, 9:03 AM EST: Brooooooklyn merged this pull request with the Graphite merge queue.

Feb 20 '24 13:02 graphite-app[bot]