shapez.io icon indicating copy to clipboard operation
shapez.io copied to clipboard

Random shape goal generation may be not what was intended

Open ShadowTheAge opened this issue 4 years ago • 1 comments

https://github.com/tobspr/shapez.io/blob/09c2320f5572f149068dfb431cc8e33aa64fadf7/src/js/game/hub_goals.js#L399

looks like availableShapes array should restrict shapes based on selected symmetry, but it is not used.

ShadowTheAge avatar Sep 25 '21 11:09 ShadowTheAge

I remember this recently being noticed, it's a discrepancy between https://github.com/tobspr/shapez.io/pull/392

https://github.com/tobspr/shapez.io/blob/75b56ee03b0db7908b20bcde4ed099153dda86dc/src/js/game/hub_goals.js#L393

and https://github.com/tobspr/shapez.io/commit/4f6d9785c16e83816233be24b427df17fc6ca2f6

https://github.com/tobspr/shapez.io/blob/4f6d9785c16e83816233be24b427df17fc6ca2f6/src/js/game/hub_goals.js#L404

EmeraldBlock avatar Sep 25 '21 14:09 EmeraldBlock