Aman Karmani
Aman Karmani
> If you want to get translated metal shader done by spirv-cross, you can use `glGetProgramBinaryOES` This is very helpful for debugging, thank you! I will try it tomorrow and...
To check quickly, I added a breakpoint in `ProgramMtl::createMslShader` to look at the metal shader. It has a similar floating point error: ``` float3 _112 = _ucolor.xyz * float3(100.0); _ucolor...
The shader is generated programmatically. In this case there's nothing in-between, because no color mapping is being applied. https://github.com/mpv-player/mpv/blob/dc24a437fb9ba2485bc8c5866542bd36254410d4/video/out/gpu/video_shaders.c#L827
``` CG_EXTERN const CFStringRef kCGColorSpaceITUR_2020_PQ_EOTF CG_AVAILABLE_BUT_DEPRECATED(10.14.6, 10.15.4, 12.6, 13.4); // Use kCGColorSpaceITUR_2100_PQ. This is only a name change, color space remains the same CG_EXTERN const CFStringRef kCGColorSpaceITUR_2020_PQ CG_AVAILABLE_BUT_DEPRECATED(10.15.4, 10.16, 13.4,...
This appears not to work correctly on Apple TV due to tvOS bugs. I have filed a report with Apple: > FB7841133 **CAMetalLayer with pixelFormat=MTLPixelFormatRGBA16Float and colorspace=kCGColorSpaceITUR_2020_PQ_EOTF will not render...
It seems to me that it is simply unsupported at this time outside macOS. But given that the first tvOS 14 Beta makes some things render now, I am hopeful...
As far as a repro, probably closest available right now is @qiudaomao's MoltenVK example in https://github.com/qiudaomao/MPVColorIssue One thing I found interesting: with the MoltenVK example, it renders colors correctly inside...
🤦 I forgot to setup the MGLContext first! I'm trying to use `MGLKView` and `MGLContext` to swap in for `EAGL*` counterparts now, and ran into some missing methods: - `MGLContext`...
After adapting to the API differences above, I was able to run my app and everything renders as expected. Very nicely done! One of the reasons I'm looking into MetalANGLE...
> eglGetProcAddress will be only 1 line of code. Which MGLKit header can I use for this? Before I only had `@import GLKit`. > Nevertheless, it might be enough for...