Terence Joubert
Terence Joubert
@DiscoPYF , can you take another look please? :-) Thanks
Hi @DiscoPYF. Can you take a look at this one when you have some time please?
@DiscoPYF, for backward compatibility, do you think it makes sense to add the async method definitions as additional methods to the interface instead of updating the existing methods. So, we...
> Do we need to make allow_dirty_read nullable? It seems like we can get away with just defaulting to False. Thanks @joowani. I have updated the default value of the...
Hi @DiscoPYF , the aim of this PR is to pass a `ApiHeaderProperties` object to every single method that calls the API. That will allow calling clients to pass the...
See https://github.com/ArangoDB-Community/arangodb-net-standard/pull/431#pullrequestreview-1156131798
> Good idea to refactor into separate classes for analyzer properties 👍 > > I left a few minor comments. One thing I want to discuss before merging: > >...
@DiscoPYF, I have revived this PR for your review (our discussions). Here's the update: - I've updated the PR from the `master` branch. - I've brought `AnalyzerProperties` back in as...
@DiscoPYF Thanks for this suggestion. I think it makes perfect sense.
@DiscoPYF , this PR is the response-related aspect of the feature only. Please the PR for request-related stuff first: https://github.com/ArangoDB-Community/arangodb-net-standard/pull/467