tink icon indicating copy to clipboard operation
tink copied to clipboard

Allow to create Ed25519Sign.KeyPair with a given private key.

Open aartikov opened this issue 4 years ago • 3 comments

This change will allow to create Ed25519Sign.KeyPair with a given private key. The usecase is to create a key pair from bip39 mnemonic:

val mnemonic = MnemonicCode("user input")
val privateKey = mnemonic.toEntropy()
val keyPair = Ed25519Sign.KeyPair.createKeyPair(privateKey)

val publicKey = keyPair.publicKey
val signer = Ed25519Sign(keyPair.privateKey)

aartikov avatar Nov 23 '20 15:11 aartikov

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Nov 23 '20 15:11 google-cla[bot]

@googlebot I signed it!

aartikov avatar Nov 23 '20 15:11 aartikov

@tholenst Could you please review it?

aartikov avatar Jan 27 '21 07:01 aartikov

Hi @aartikov, thanks for your PR, sorry for the time it took to get to it. An equivalent API was added in this commit and thus the API added by this PR would be redundant. I am going to close this PR, please feel free to reopen it if you think there is something missing.

morambro avatar Jan 26 '23 09:01 morambro