RaceChronoDiyBleDevice

RaceChronoDiyBleDevice copied to clipboard

@timurrrr this is my first pull request ever :D I'm a git-hub n00b so maybe I'm doing something wrong :) I've created the mazda_mx5_nc.md as discussed over the RaceChrono. I've also added a sort of reverse engineering how to that might help others in finding can id codes for their cars. I've a 2016 Golf so I think I'll start digging in that one once I finish with the NC. Please bear in mind English is not my mother tongue (I'm Italian) so there may be some odd sentence constructions...

Of course the min Read Me and RaceChronoDiyBleDevice.ino were edited to reflect the differences on the two devices assembly and destinations. I'm going to investigate if I really need the 120 ohm terminator on the device when connected to the OBD port. I'm not familiar with my car diagram but if it is somewhat similar to industrial CAN-Bus the terminator is already on the car. By the way, the system is working with or without the terminator jumper.

I've also digged a bit on ND CAN-Bus. I found something interesting on miata.net forum: it is partial and possibly only for ND and not for ND2, I'm going to write to the author, maybe he is interested in extending the database collection.

Finally, do you think it is possible to drop the filtering at MCP2515 level? I'm also going to try faster rates for more IDs (steering and accelerator) and see what is happening.

Thank you, Sebastian

Thanks a lot for working on this. I'm also a GitHub n00b, but let's figure it out :)

Here are some ideas:

1. The can_db/mazda_mx5_nc.md file is great as is! If you're ok with that, I can just pull that one file and check it in mentioning you in the commit description — just to simplify things.

2. The can_db/reverse_engineering_how_to.md should be a very useful resource! It does however reference a bunch of JPGs that are pretty large. See the existing files in /images — they are 150k–250k each. A possible solution here is that you can create your own GitHub project with just that doc and images, and I'll be happy to reference it — instead of making it part of this project. I think this option makes sense, as many users of the main project will not necessarily have the necessity to reverse-engineer their car's protocol (hopefully the PIDs for their car will already be documented! :))

3. We'll need to figure out how to merge changes to README. It looks like you've changed the README to be along the lines of "hey there's this project for FT86, and this is a fork for NC Miata". If I merge this now, my project will "become" an NC Miata project. So there's some work needed here. Assuming more cars will be added in the future (e.g. I'm thinking about adding ND2 Miata), I'd prefer the README to be less detailed, and more car-agnostic; and put the details on car-specific pages.

4. re: CAN filtering — it might not be needed anymore, but before https://github.com/sandeepmistry/arduino-CAN/pull/46 and some fixes to my hardware layout this was necessary to improve stability. We do need to do filtering at some point, as the Bluetooth transmit rate is not sufficient to send everything we get from CAN.

Hi Timurr,

1. Yes go ahead. I know there is some minor changes to do to equations, but I'll have the opportunity to do that later in the year... here in Italy we still have periodic lock downs, I don't know when I'll be able to hit the race track.

2. Done that https://github.com/jeby/CANBUS_RevEng with smaller pics :) also smaller in the RaceChronoBLE repository, but I agree, let's keep things simple

3. Yes, as said, git-hub n00b here, I didn't think about merging! Actually the real changes in the read me are related to the alternative building with OBD port and 12v-5v step down for powering the device via OBD. I used a white breadboard to make clear it was an alternative. I agree the read me shall be car agnostic. If you agree I'll edit my version of the Read Me as soon as possible to reflect this philosophy, and then we'll check again! 3b. Then this issue will be also in the RaceChronoDiyBleDevice.ino, if you merge then it will work for MX5 NC only. I still have to catch up with C++ coding (it seems I'm a n00b of everything related to this project... well, yes, I am!) but do you think it will be possible to have the car selectable? Like storing IDs and update rates divider in a support file that the user will edit? Oooor... I just rename RaceChronoDiyBleDevice.ino to RaceChronoDiyBleDevice_MazdMX5NC.ino 😄

4. I understand that filtering has to be done, but when you do it at MCP2515 level I understand you can filter up to 6 IDs, while maybe one may want to receive 7 or 8, with the additional 2 being refreshed only 1 or 2 time per second. That one is me 😄 I understand that AOL is filtering at Arduino level, but I didn't his code yet.

Committed 6d400b9b3d415ca57aad45d1c3f01c6622cec8bd, please rebase before uploading a new version. Also would appreciate if you squash your local commits into one.

Thanks for your help!

Timurrrr,

Sorry to bother, can you please explain how to do the rebase and the squash as if you are explaining it to a 12 yo from another galaxy? :) Just not that I worked only on GitHub web, even if I've bot git and gh installed on Ubuntu.

Thanks!

Il giorno mer 17 mar 2021 alle ore 06:47 Timur Iskhodzhanov < @.***> ha scritto:

Committed 6d400b9 https://github.com/timurrrr/RaceChronoDiyBleDevice/commit/6d400b9b3d415ca57aad45d1c3f01c6622cec8bd, please rebase before uploading a new version. Also would appreciate if you squash your local commits into one.

Thanks for your help!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/timurrrr/RaceChronoDiyBleDevice/pull/1#issuecomment-800813271, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB5QAKVVZVAGXG3FJBLW43TEA66BANCNFSM4Y5X6CFA .

Well, nevermind, I think I did it :)

Il giorno ven 19 mar 2021 alle ore 17:21 Jeby @.***> ha scritto:

Timurrrr,

Sorry to bother, can you please explain how to do the rebase and the squash as if you are explaining it to a 12 yo from another galaxy? :) Just not that I worked only on GitHub web, even if I've bot git and gh installed on Ubuntu.

Thanks!

Il giorno mer 17 mar 2021 alle ore 06:47 Timur Iskhodzhanov < @.***> ha scritto:

Committed 6d400b9 https://github.com/timurrrr/RaceChronoDiyBleDevice/commit/6d400b9b3d415ca57aad45d1c3f01c6622cec8bd, please rebase before uploading a new version. Also would appreciate if you squash your local commits into one.

Thanks for your help!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/timurrrr/RaceChronoDiyBleDevice/pull/1#issuecomment-800813271, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB5QAKVVZVAGXG3FJBLW43TEA66BANCNFSM4Y5X6CFA .

Filed issue #4 to refactor the code before we can customize the code for more than one car