callisto icon indicating copy to clipboard operation
callisto copied to clipboard

What do you think if I create an OAuthHelpers sample page?

Open kimsk opened this issue 12 years ago • 6 comments

Hi Tim, Thanks for nice project. I don't see a sample for OAuthHelps in the Callisto.TestApp yet. What do you think if I add my OAuth sample here, http://code.msdn.microsoft.com/windowsapps/Twitter-OAuth-Example-3a99967f, and modify it to use callisto's OAuthHelpers (currently, it uses my own adhoc OAuth class, but I already modify it using callisto, and it works great)?

Thanks, Karlkim

kimsk avatar Mar 21 '13 04:03 kimsk

Sounds great!

timheuer avatar Mar 22 '13 02:03 timheuer

Cool! I will work on it now.

kimsk avatar Mar 22 '13 04:03 kimsk

I notice that WebPairCollection.Sort() method and the line copy.Sort in OAuthTools.SortParametersExcludingSignature have been commented out. The code looks fine to me though. Do you want me to add them back with the OAuth sample page?

callisto-oauthhelper-commit

kimsk avatar Mar 23 '13 01:03 kimsk

I don't think the Sort call worked in WinRT...there was one extension method that wasn't working which is why I commented it out.

timheuer avatar Mar 24 '13 16:03 timheuer

I might be wrong, but when I uncommented those lines, the SortParametersExcludingSignature method is working as expected. The method doesn't returns a sorted parameter collection right now :-)

I wrote a simple unit tests for Sort method in the Callisto.OAuth.WebPairCollection here.

https://gist.github.com/kimsk/5232991

kimsk avatar Mar 24 '13 18:03 kimsk

By the way, since OAuthTools.SortParametersExcludingSignature doesn't really return sorted WebPairCollection as expected. Should this be another issue?

kimsk avatar Mar 29 '13 01:03 kimsk