timeoff-management-application

timeoff-management-application copied to clipboard

This change allows users on start to set the companys holiday year start (for example April or defaulted to January) with the holiday year running from then (for example 1st April-> 31st March)

We had this problem within our Company and looking though the issues it appears several users had similar request. See #218 , #114 and #354

I has set this to WP as I am never new to this project and believe there will likely be some feedback or changes to make.

@gamereat have you noticed this PR breaks the functions for manual adjustment of leave? I've been trying to work out where it goes wrong, but have failed to find the cause so far.

@gamereat have you noticed this PR breaks the functions for manual adjustment of leave? I've been trying to work out where it goes wrong, but have failed to find the cause so far.

Hey @portableant, I hadn't noticed. I will take a look into that soon. As i said this is a large change so was likely to introduce elements that were not expected.

@gamereat have you noticed this PR breaks the functions for manual adjustment of leave? I've been trying to work out where it goes wrong, but have failed to find the cause so far.

Hey @portableant, I hadn't noticed. I will take a look into that soon. As i said this is a large change so was likely to introduce elements that were not expected.

Much needed change, so well done for attempting to make this work!

@portableant that should the manual adjustment fix now

@gamereat I will give it a go! Thank you for having a look.

Thanks for putting the work into this!

Just had a test of this and looks like it (mostly) works, a few issues noticed with it:

• The periods are still displayed as calendar years in the view (e.g. 2022 runs from August 2022 to July 2023 if year start is set to August)
• Holidays which overlap the boundary take from the previous year only (requesting a 5 day holiday where 2 are in July and one is in August will result in 5 taken from the current year's allowance)
• New employees that start halfway through a period do not have a scaled allowance (they get a full year of allowance, tested with August start date by setting a user to start in the middle of November, they still had the default 20 days)

Is there any likelihood of seeing this integrated into main / officially supported?

Thanks for putting the work into this!

Just had a test of this and looks like it (mostly) works, a few issues noticed with it:

• The periods are still displayed as calendar years in the view (e.g. 2022 runs from August 2022 to July 2023 if year start is set to August)
• Holidays which overlap the boundary take from the previous year only (requesting a 5 day holiday where 2 are in July and one is in August will result in 5 taken from the current year's allowance)
• New employees that start halfway through a period do not have a scaled allowance (they get a full year of allowance, tested with August start date by setting a user to start in the middle of November, they still had the default 20 days)

Is there any likelihood of seeing this integrated into main / officially supported?

Yeah,

I'm unlikely to be able to support this PR much further. I had hoped to get some progress getting it offically supported when I first set work on this but over the past year my company has moved away from timeoff.

Regarding those issues, The second one was a core issue with Timeoff outside this branch and likely need to be addressed independently.

Thanks for getting back to me so quick!

We're currently looking at some options for this stuff, I know it's a bit off topic for this thread then but did you find a suitable alternative that did have this feature? Any recommendations would be helpful!

Thanks for getting back to me so quick!

We're currently looking at some options for this stuff, I know it's a bit off topic for this thread then but did you find a suitable alternative that did have this feature? Any recommendations would be helpful!

We moved to BreathHR. It does cost money but compared to everything else it cheap and has a lot of other features that once you grow as a business is super useful.

We found Time off was fine when it was a small team and I had time to maintain this branch and other issues but as we grew my time was more elsewhere