check_docker

check_docker copied to clipboard

Add certificates files for docker engine daemon socket TLS for production environment (see https://docs.docker.com/engine/security/https/)

Add modifications to check_swarm.py script

Thanks for the PR. I am reviewing this change and looking into the test results. I will keep you posted.

This (still) works for the latest release. Would like to see it merged to master.

Me too however there are still quality issues that need to be addressed. The tests need to pass and a error message should be added for bad argument usage. I don't have a test environment for this daemon configuration.

I would help but I have no good simulation of your environment to use for testing. Perhaps you can update the Vagrantfile to provide a Docker daemon with a suitable configuration?

Here are some hints on how I do testing. https://github.com/timdaman/check_docker/blob/master/DEVLOPEMENT.md

@osfrance @timdaman need help with this one?

@rbw I could use some. The biggest issue is I don't have a Docker server setup with cert auth. I could try to make one but I figure someone who has something in the field should probably be the person to do that since they know what it should look like in operation.

Then there is writing up the tests and polishing the args, I can help with some of that but assistance is most welcome.