Tim Harper

Results 93 comments of Tim Harper

This is because these are not implemented. PR welcome.

Resolved somewhat with the json bindings?

@tomatohf I'm glad to hear you used the Binding interface; I was responsible for those changes and have recently submitted a pull-request to include my `play-json` integration: https://github.com/SpinGo/handlebars.scala/commit/4a7483460122bfab30fac8a5d1b3340d08f599d7 With which...

Great; do you have the code somewhere? I could help review it and get it ready for merge. The `play-json` integration was merged into handlebars primary.

You could just post a gist Sent from my iPhone > On Sep 1, 2015, at 08:18, Tomato [email protected] wrote: > > I have the code in our private github...

Well, lol here we are 5 months later! I merged your gist and made a few modifications to it; it's here: https://github.com/mwunsch/handlebars.scala/tree/lift-json Could you write some tests for it? Just...

@tomatohf sure! Pull request to lift-json branch would be optimal. Or, you could just amend the commit from the lift-json branch and send a pull request for master.

I know this is 10 months later; Could you add some tests with an example for this?